Bug 558958

Summary: [E4] Class name filter not working in "Find Contribution Class" dialog
Product: [Eclipse Project] Platform Reporter: Sravan Kumar Lakkimsetti <sravankumarl>
Component: UIAssignee: Benedikt Kuntz <benedikt.kuntz>
Status: NEW --- QA Contact:
Severity: major    
Priority: P3 CC: akurtakov, benedikt.kuntz, kalyan_prasad, Lars.Vogel
Version: 4.15   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/155550
Whiteboard:
Attachments:
Description Flags
Screenshot none

Description Sravan Kumar Lakkimsetti CLA 2020-01-09 04:24:11 EST
Created attachment 281424 [details]
Screenshot

Class name filter stops working once a special character is added(ex . /)

Steps to reproduce
1. create a e4 RCP app
2. open application.e4xmi
3. add a new addon
4. click find button against class url
5. in the Find Contribution Class dialog enter "org." 

after typing . results vanish

If this is not from platform ui please move appropriately
Comment 1 Lars Vogel CLA 2020-01-09 04:34:05 EST
Benedikt, can you take this one?
Comment 2 Eclipse Genie CLA 2020-01-09 10:34:29 EST
New Gerrit change created: https://git.eclipse.org/r/155550
Comment 3 Benedikt Kuntz CLA 2020-01-09 10:42:36 EST
Some comments to the Gerrit: This only fixes the issue when having Workspace or Target Platform selected as search scope. Then, TargetPlatformClassContributionCollector is used. Within this class, I added two changes: When loading the classes, the package names of the classes are derived from its file path, but the code assumed unix path seperators.
Also, the package name was not considered in the pattern matching.
When selecting Project as scope, PDEClassContributionProvider is used, there should be another Gerrit for that class...
Comment 4 Alexander Kurtakov CLA 2020-06-01 03:47:39 EDT
Too late for 4.16.