Bug 55822

Summary:	[CoolBar] CoolBarManager.setLayout is poor API
Product:	[Eclipse Project] Platform	Reporter:	Nick Edgar <n.a.edgar>
Component:	UI	Assignee:	Nick Edgar <n.a.edgar>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	api
Version:	3.0
Target Milestone:	3.0 M9
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Nick Edgar

2004-03-23 22:36:25 EST

build I20040323

CoolBarManager.setLayout has a couple of problems:
1. its Javadoc talks about internals
2. it takes an ArrayList of unspec'ed element type instead of IContributionItem[] 
3. it talks about order, but really it allows the whole set of items to be
replaced, not just reordered.

Should change to take an IContributionItem[] (and copy the array).

Comment 1 Nick Edgar

2004-03-23 22:36:56 EST

And rename it to setItems(IContributionItem[])

Comment 2 Nick Edgar

2004-03-23 22:38:40 EST

Should also revisit resetLayout.  Avoid the term layout to avoid confusion with
SWT layouts, e.g. resetItemOrder.

Comment 3 Nick Edgar

2004-05-09 01:32:22 EDT

Done.