Bug 557993

Summary: Coloring of Refactoring Preview swaps additions/removals
Product: [Eclipse Project] JDT Reporter: Stephan Herrmann <stephan.herrmann>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: jack.mckalling, mateusz.matela, p.bodnar
Version: 4.14   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=550896
https://bugs.eclipse.org/bugs/show_bug.cgi?id=508257
https://bugs.eclipse.org/bugs/show_bug.cgi?id=516450
Whiteboard: stalebug
Attachments:
Description Flags
colored preview of pull-up refactoring none

Description Stephan Herrmann CLA 2019-12-07 13:13:54 EST 
Created attachment 281160 [details]
colored preview of pull-up refactoring

Using I20191125-1800, the coloring in the refactoring preview is wrong: removals are shown with green background, additions have a red background.

At first I thought this to be caused by allocating left/right panes (which would make it a duplicate of bug 550896), but "Swap Left an Right View" takes the wrong color along.
Comment 1 Stephan Herrmann CLA 2020-02-04 16:53:26 EST 
*** Bug 559848 has been marked as a duplicate of this bug. ***
Comment 2 Stephan Herrmann CLA 2020-05-10 06:28:34 EDT 
I'm not sure if bug 508257 and bug 516450 have a finger in the pie here?
Comment 3 Eclipse Genie CLA 2022-05-01 08:46:00 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Petr Bodnar CLA 2022-11-13 06:35:28 EST 
Still an issue in the newest Eclipse.

(In reply to Stephan Herrmann from comment #2)
> I'm not sure if bug 508257 and bug 516450 have a finger in the pie here?

From what I have tested and what was written so far, the "Swap left and right" option and behavior, while it might be _somewhat_ related to the root of the problem, DOESN'T affect the coloring problem described here.

This is also supported by this statement from Lars Vogel at bug 550896:

> Compare started to show colors in the 4.13 release, so I think this is unrelated. Please open a new bug, if the refactor dialog still uses wrong colors.