Summary: | [EditorMgmt] ctrl+e shortcut doesn't activate editor properly | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Erich Gamma <erich_gamma> | ||||
Component: | UI | Assignee: | Chris McLaren <csmclaren> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | major | ||||||
Priority: | P1 | CC: | csmclaren, douglas.pollock, jeem, kai-uwe_maetzel, markus.kell.r, sxenos, Tod_Creasey | ||||
Version: | 3.0 | Keywords: | accessibility | ||||
Target Milestone: | 3.0 M8 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Erich Gamma
2004-03-23 13:23:15 EST
Erich, which build was this in? sorry...200403231208 The outline is affected by this as well. Still happens in build I20040325_0010 On Linux-GTK, focus disappears completely. Pressing tab or arrow keys doesn't seem to cause any visible effect. This is an accessibility issue, as a mouse is required once this state is entered. *** Bug 56048 has been marked as a duplicate of this bug. *** Chris, unless you're already looking at this I'm going to give it a peek. In EditorList.gotoSelectedElement() we're setting the selection in the presentation to the selected editor rather than activating hte editor from the workbench page. I fixed a symmetrical bug in views by making a change to PartTabFolder.presentationSelectionChanged. Here's the new version: private void presentationSelectionChanged(IPresentablePart newSelection) { LayoutPart newPart = getLayoutPart(newSelection); if (newPart == current) { return; } setSelection(newPart); if (newPart != null) { newPart.setFocus(); } // set the title of the detached window to reflect the active tab Window window = getWindow(); if (window instanceof DetachedWindow) { window.getShell().setText(newSelection.getTitle()); } } ...what I added was the setFocus bit. I suspect a similar change will work for EditorWorkbook. Created attachment 8895 [details]
Patch for org.eclipse.ui.workbench
Could a pair of UI committers please look at this and commit if it's OK? Preferably at least one of you will have ownership of the presentation work... i will take it. thanks.. your patch seems good. i have just encountered a variant of this problem, both with the patch and without, that i can reproduce within about 30 seconds though exact steps elude me right now: using ctrl+e, picking an editor, ctrl+o, esc (or select), repeat, sometimes typing within the editor before i select another, i get to a point where neither ctrl+e or ctrl+o works. i know there are some child shell issues on swt on gtk, perhaps something here is to blame. Please see Bug 56231. Is that behaviour already existent (i.e., with or without the patch)? yes doug thanks, i did log 56261 but will close that as a duplicate. closing this pr as fixed.. |