Bug 553227

Summary:	Custom partstack renderer's lazyLoader not reinitialized
Product:	[Eclipse Project] Platform	Reporter:	Tobias Weißer <tobias.weisser>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	tobias.weisser
Version:	4.14
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Tobias Weißer

2019-11-19 11:02:47 EST

I've a custom partstack renderer in place, which is basically working as intended.

However, the lazyLoader EventHandler in the LazyStackRenderer is unsubscribed from the eventBroker as soon as the IEclipseContext is disposed, but not the renderer itself.

If a new partstack is created afterwards, the PartRenderingEngine just uses the previously created custom renderer, but is not subscribing the lazyLoader EventHandler to the eventBroker again.

This results in newly activated tabs not being shown anymore and some other strange behavior.

ps: I only need this custom renderer because the NoDetach tag is completely ignored by the StackRenderer#populateTabMenu method. I think this should be checked like it is done for the NoClose tag already!

Greetings
Tobias