Bug 552372

Summary: Eclipse fails to start with 'org.eclipse.datatools.enablement.sybase.feature' installed
Product: [Eclipse Project] Platform Reporter: Martin Coufal <mcoufal>
Component: IDEAssignee: Andrey Loskutov <loskutov>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: akurtakov, karsten.thoms, loskutov, mat.booth, vkadlcik
Version: 4.14Keywords: regression
Target Milestone: 4.14 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/151516
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=85cca0f79d0fa796995271e4b09047f691b8411f
Whiteboard:
Bug Depends on:    
Bug Blocks: 552175    
Attachments:
Description Flags
workspace log
none
reproducing script (desctructive!) none

Description Martin Coufal CLA 2019-10-24 05:57:31 EDT
Created attachment 280403 [details]
workspace log

Eclipse fails to start with: BundleException: Exception in org.eclipse.core.resources.ResourcesPlugin.start() of bundle org.eclipse.core.resources. For more details, see workspace log.

How to reproduce:
1. install 'org.eclipse.datatools.enablement.sybase.feature.feature.group'
2. run eclipse without parameter `-data`

Attaching reproduction script...

My configuration:
RHEL-7.8-20191009.6
Java 1.8.0_232-ea
Eclipse Platform I20191020-1800
Data Tools Platform Enablement for Sybase 1.14.101.201811012051
Comment 1 Martin Coufal CLA 2019-10-24 05:58:23 EDT
Created attachment 280404 [details]
reproducing script (desctructive!)
Comment 2 Andrey Loskutov CLA 2019-10-24 06:59:46 EDT
I fear bug 552175 must be reverted.
Comment 3 Eclipse Genie CLA 2019-10-24 07:48:39 EDT
New Gerrit change created: https://git.eclipse.org/r/151516
Comment 4 Andrey Loskutov CLA 2019-10-24 07:59:48 EDT
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/151516

Karsten, this removes the "eager activation" and the main part of the bug 	552175. I've wrote in bug 552175 comment 26 / commit message why the chosen approach is dangerous.

In bug 552175 we should check *if* there is a way to do this JXPath optimization *without* loading classes / activating bundles.

Current state with eager bundle activation is unfortunately not acceptable, my bad I haven't seen this earlier.
Comment 6 Andrey Loskutov CLA 2019-10-25 03:12:53 EDT
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/151516 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=85cca0f79d0fa796995271e4b09047f691b8411f

This fix should be now in the build https://download.eclipse.org/eclipse/downloads/drops4/I20191024-1800/

@Martin: please verify that this fixes your issue.
Comment 7 Martin Coufal CLA 2019-10-25 03:47:08 EDT
(In reply to Andrey Loskutov from comment #6)
> (In reply to Eclipse Genie from comment #5)
> > Gerrit change https://git.eclipse.org/r/151516 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> > ?id=85cca0f79d0fa796995271e4b09047f691b8411f
> 
> This fix should be now in the build
> https://download.eclipse.org/eclipse/downloads/drops4/I20191024-1800/
> 
> @Martin: please verify that this fixes your issue.

Thanks Andrey, the issue is fixed in I20191024-1800.
Comment 8 Andrey Loskutov CLA 2019-10-25 04:02:57 EDT
Thanks Martin for reporting & verification!