Bug 552144

Summary:

Filtering in Quick switch editor (Ctrl+E) not working correctly

Product:

[Eclipse Project] Platform

Reporter:

Noopur Gupta <noopur_gupta>

Component:

Assignee:

Patrik Suzzi <psuzzi>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, eclipse, mauromol, psuzzi, rolf.theunissen

Version:

4.14

Target Milestone:

4.15 M1

Hardware:

OS:

Windows 10

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=548481
https://git.eclipse.org/r/153876
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=909e1b1e334a8c9d43d16fc1754b355b931e0155

Whiteboard:

Bug Depends on:

Bug Blocks:

553792

Attachments:

Description	Flags
Demo of the Ctrl+E dialog with adjusted behaviour	none

Description Noopur Gupta

2019-10-16 08:58:08 EDT

I20191011-1800

- Keep a class JavaElement.java open in the workspace.

1) Invoke Ctrl+E (quick switch editor), type "JE" i.e. camel case for JavaElement.java. 
=> No results found.

2) Another issue is that typing "J" highlights the "j" in ".java" rather than "J" in any type starting with "J".

Comment 1 Rolf Theunissen

2019-10-16 11:25:14 EDT

This filtering does work for the window used for the chevron in the PartStack. The two implementation should be aligned anyhow, see Bug 548481.

Comment 2 Patrik Suzzi

2019-11-26 02:24:15 EST

I'll take it and try to fix before 2019-12 M3 

Cause: bad pattern match

We should check the org.eclipse.ui.dialogs.StyledStringHighlighter's methods:
 - StyledStringHighlighter.escapeSpecialCharacters(String)
 - StyledStringHighlighter.highlight(String, String, StyledString, Styler)

Debuggable in WorkbookEditorsHandlern line 150 calling StyledStringHighlighter#highlight (line 23 and 84)

Comment 3 Patrik Suzzi

2019-12-05 00:44:56 EST

Created attachment 280872 [details]
Demo of the Ctrl+E dialog with adjusted behaviour

The change will follow shortly, as soon as I complete testing.

Comment 4 Eclipse Genie

2019-12-05 01:46:24 EST

New Gerrit change created: https://git.eclipse.org/r/153876

Comment 5 Eclipse Genie

2019-12-14 11:00:53 EST

Gerrit change https://git.eclipse.org/r/153876 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=909e1b1e334a8c9d43d16fc1754b355b931e0155

Comment 6 Patrik Suzzi

2019-12-18 00:09:10 EST

*** Bug 519302 has been marked as a duplicate of this bug. ***

Comment 7 Mauro Molinari

2020-02-13 04:44:18 EST

Does this fix address bug #543191 or bug #292884?