Bug 550832

Summary:	Remove gif which we left during the move to png files
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	IDE	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, loskutov, ma.becker
Version:	4.13
Target Milestone:	4.17 M1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/149411 https://git.eclipse.org/r/163429 https://git.eclipse.org/r/163430 https://bugs.eclipse.org/bugs/show_bug.cgi?id=563480 https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=4f930563e77818bbc00b4417fb29eca3631dacc1 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=30a3908271366b21ec15e2f5de4b77a91e33089d https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=c094c33c077db74c27fe0256912225f80145ae09 https://git.eclipse.org/r/164756 https://git.eclipse.org/r/164759 https://git.eclipse.org/r/164760 https://git.eclipse.org/r/164762 https://git.eclipse.org/r/164763 https://git.eclipse.org/r/164764 https://git.eclipse.org/r/164765 https://git.eclipse.org/r/164766 https://git.eclipse.org/r/164768 https://git.eclipse.org/r/164769 https://git.eclipse.org/r/164770 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=9c72cafe2fc460bc5bda838106492df9d5fa2525 https://git.eclipse.org/r/164772 https://git.eclipse.org/r/164773 https://git.eclipse.org/r/164774 https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=6e35310599ab5daebc2a0c981137478b720e9c8a https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=cc1977f7a7fb462f2f4d8c9708201e5f4625ee50 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=36551d00f0626337d2f2c12629e3e892591a1d02 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=4fbf902102ed5ce3b0a325f24793352d338f1ffd https://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=494ada4f81a713f73c0b3e5dd2d71e572af6e21a https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=9f4636a908b8d4b6b82f1681125faa3ed6b32e55 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=6d3245f2058201dba1f926e3a982dbfbc1ce4b6a https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a82101c1903905d37d90d9413b4f74816b3677fd https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=189a63aa70053cd60226639335d17eba84fc6396 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=dcfa044502b13c30c56a41b0d4fcca8ea0608dc6 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=18247716387ebb8b908b6c5f2507f5f8ce78d55e https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=9f1f6553f4b490c3590e4cb549317c9056fd4fdb https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=6edf4dba6c88668b945ee57d3df82e08c40edb20 https://bugs.eclipse.org/bugs/show_bug.cgi?id=574805
Whiteboard:

Description Lars Vogel

2019-09-06 05:10:11 EDT

During the transition from gifs to png we left a view gifs as the opened views would persists them. I suggest to remove them now, its been a few years and continuing to carry this "garbage" is not good for our users in general as they unnecessary increase download size.

Comment 1 Lars Vogel

2019-09-06 05:10:36 EDT

Matthias, what you you think?

Comment 2 Lars Vogel

2019-09-06 05:18:17 EDT

Also, I think we can clean the eclipse.platform.image master from gifs.

Comment 3 Matthias Becker

2019-09-06 08:38:51 EDT

(In reply to Lars Vogel from comment #2)
> Also, I think we can clean the eclipse.platform.image master from gifs.

I already did this. See https://git.eclipse.org/r/#/c/145105/

Comment 4 Lars Vogel

2019-09-06 10:18:33 EDT

No objections for the normal repo?

Comment 5 Matthias Becker

2019-09-06 10:45:10 EDT

(In reply to Lars Vogel from comment #4)
> No objections for the normal repo?

I am not sure about this. Is the persisteted path to the GIFs (I think in workbench.xmi) updated once you open that view? If this is the case we can assume that all (most) users have opened these views in old workspaces. If not then these path remain as long as the workspace lives.

Comment 6 Lars Vogel

2019-09-11 08:21:29 EDT

(In reply to Matthias Becker from comment #5)
> (In reply to Lars Vogel from comment #4)
> > No objections for the normal repo?
> 
> I am not sure about this. Is the persisteted path to the GIFs (I think in
> workbench.xmi) updated once you open that view? If this is the case we can
> assume that all (most) users have opened these views in old workspaces. If
> not then these path remain as long as the workspace lives.

The can simply close the view and open it again. We can add a section to the N&N so that it is easier to find for the user.

Comment 7 Eclipse Genie

2019-09-12 09:06:18 EDT

New Gerrit change created: https://git.eclipse.org/r/149411

Comment 8 Lars Vogel

2019-09-13 22:54:26 EDT

I postphone this for another release.

Comment 9 Lars Vogel

2020-05-22 09:45:43 EDT

Plan to do this early 4.17

Comment 10 Eclipse Genie

2020-05-22 09:48:30 EDT

New Gerrit change created: https://git.eclipse.org/r/163429

Comment 11 Eclipse Genie

2020-05-22 09:51:41 EDT

New Gerrit change created: https://git.eclipse.org/r/163430

Comment 12 Eclipse Genie

2020-05-22 09:54:56 EDT

Gerrit change https://git.eclipse.org/r/163430 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=4f930563e77818bbc00b4417fb29eca3631dacc1

Comment 13 Eclipse Genie

2020-06-11 13:20:21 EDT

Gerrit change https://git.eclipse.org/r/149411 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=30a3908271366b21ec15e2f5de4b77a91e33089d

Comment 14 Eclipse Genie

2020-06-11 14:43:24 EDT

Gerrit change https://git.eclipse.org/r/163429 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=c094c33c077db74c27fe0256912225f80145ae09

Comment 15 Eclipse Genie

2020-06-12 02:18:47 EDT

New Gerrit change created: https://git.eclipse.org/r/164756

Comment 16 Eclipse Genie

2020-06-12 02:38:19 EDT

New Gerrit change created: https://git.eclipse.org/r/164759

Comment 17 Eclipse Genie

2020-06-12 02:39:30 EDT

New Gerrit change created: https://git.eclipse.org/r/164760

Comment 18 Eclipse Genie

2020-06-12 02:42:06 EDT

New Gerrit change created: https://git.eclipse.org/r/164762

Comment 19 Eclipse Genie

2020-06-12 02:42:07 EDT

New Gerrit change created: https://git.eclipse.org/r/164763

Comment 20 Eclipse Genie

2020-06-12 02:42:18 EDT

New Gerrit change created: https://git.eclipse.org/r/164764

Comment 21 Eclipse Genie

2020-06-12 02:45:30 EDT

New Gerrit change created: https://git.eclipse.org/r/164765

Comment 22 Eclipse Genie

2020-06-12 02:47:42 EDT

New Gerrit change created: https://git.eclipse.org/r/164766

Comment 23 Eclipse Genie

2020-06-12 02:47:53 EDT

New Gerrit change created: https://git.eclipse.org/r/164768

Comment 24 Eclipse Genie

2020-06-12 02:51:15 EDT

New Gerrit change created: https://git.eclipse.org/r/164769

Comment 25 Eclipse Genie

2020-06-12 02:53:27 EDT

New Gerrit change created: https://git.eclipse.org/r/164770

Comment 26 Eclipse Genie

2020-06-12 02:53:49 EDT

Gerrit change https://git.eclipse.org/r/164756 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=9c72cafe2fc460bc5bda838106492df9d5fa2525

Comment 27 Eclipse Genie

2020-06-12 02:58:00 EDT

New Gerrit change created: https://git.eclipse.org/r/164772

Comment 28 Eclipse Genie

2020-06-12 02:58:12 EDT

New Gerrit change created: https://git.eclipse.org/r/164773

Comment 29 Eclipse Genie

2020-06-12 02:59:23 EDT

New Gerrit change created: https://git.eclipse.org/r/164774

Comment 30 Eclipse Genie

2020-06-12 03:09:08 EDT

Gerrit change https://git.eclipse.org/r/164762 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=6e35310599ab5daebc2a0c981137478b720e9c8a

Comment 31 Eclipse Genie

2020-06-12 04:22:19 EDT

Gerrit change https://git.eclipse.org/r/164769 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=cc1977f7a7fb462f2f4d8c9708201e5f4625ee50

Comment 32 Eclipse Genie

2020-06-12 04:22:40 EDT

Gerrit change https://git.eclipse.org/r/164760 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=36551d00f0626337d2f2c12629e3e892591a1d02

Comment 33 Eclipse Genie

2020-06-12 04:22:51 EDT

Gerrit change https://git.eclipse.org/r/164764 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=4fbf902102ed5ce3b0a325f24793352d338f1ffd

Comment 34 Eclipse Genie

2020-06-12 04:23:03 EDT

Gerrit change https://git.eclipse.org/r/164763 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=494ada4f81a713f73c0b3e5dd2d71e572af6e21a

Comment 35 Eclipse Genie

2020-06-12 04:23:14 EDT

Gerrit change https://git.eclipse.org/r/164759 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=9f4636a908b8d4b6b82f1681125faa3ed6b32e55

Comment 36 Eclipse Genie

2020-06-12 04:49:28 EDT

Gerrit change https://git.eclipse.org/r/164765 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=6d3245f2058201dba1f926e3a982dbfbc1ce4b6a

Comment 37 Eclipse Genie

2020-06-12 11:20:22 EDT

Gerrit change https://git.eclipse.org/r/164766 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a82101c1903905d37d90d9413b4f74816b3677fd

Comment 38 Eclipse Genie

2020-06-15 02:19:49 EDT

Gerrit change https://git.eclipse.org/r/164772 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=189a63aa70053cd60226639335d17eba84fc6396

Comment 39 Eclipse Genie

2020-06-15 07:09:33 EDT

Gerrit change https://git.eclipse.org/r/164768 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=dcfa044502b13c30c56a41b0d4fcca8ea0608dc6

Comment 40 Eclipse Genie

2020-06-16 17:28:00 EDT

Gerrit change https://git.eclipse.org/r/164773 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=18247716387ebb8b908b6c5f2507f5f8ce78d55e

Comment 41 Eclipse Genie

2020-06-16 19:56:25 EDT

Gerrit change https://git.eclipse.org/r/164774 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=9f1f6553f4b490c3590e4cb549317c9056fd4fdb

Comment 42 Eclipse Genie

2020-06-17 10:52:06 EDT

Gerrit change https://git.eclipse.org/r/164770 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=6edf4dba6c88668b945ee57d3df82e08c40edb20

Comment 43 Lars Vogel

2020-06-17 11:02:07 EDT

I think we are done here.

Comment 44 Andrey Loskutov

2021-07-12 12:18:33 EDT

(In reply to Lars Vogel from comment #43)
> I think we are done here.

This caused a regression, see bug 574805. "Workaround" from comment 6 isn't working, the same broken icon is shown after restart.