Summary: | [CSS] [Forms] Add possibilities to style ExpandableComposite, Section | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Benedikt Kuntz <benedikt.kuntz> | ||||||
Component: | UI | Assignee: | Benedikt Kuntz <benedikt.kuntz> | ||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P3 | CC: | Lars.Vogel, ralph.gerbig | ||||||
Version: | 4.12 | Keywords: | noteworthy | ||||||
Target Milestone: | 4.14 M1 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 10 | ||||||||
See Also: |
https://git.eclipse.org/r/147354 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6e663046669162b24bf8f3da91e9cce30d6f2ae6 https://git.eclipse.org/r/150250 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=fa40a43d480393c09f79a7654f4c44d77f18ecd4 |
||||||||
Whiteboard: | |||||||||
Bug Depends on: | 559154 | ||||||||
Bug Blocks: | 551494, 551532 | ||||||||
Attachments: |
|
Description
Benedikt Kuntz
2019-08-09 04:15:05 EDT
New Gerrit change created: https://git.eclipse.org/r/147354 Is your change also addressing https://bugs.eclipse.org/bugs/show_bug.cgi?id=531532 ? Especially, the case when the heading becomes so dark that it is not possible to read it anymore? I th(In reply to Ralph Gerbig from comment #2) > Is your change also addressing > https://bugs.eclipse.org/bugs/show_bug.cgi?id=531532 ? > > Especially, the case when the heading becomes so dark that it is not > possible to read it anymore? The patch adds css stylings (swt-titlebar-color for Sections and tb-toggle-color,tb-toggle-hover-color for Sections and ExpandableComposites). So I think one could use this to adapt the dark mode css colors. New Gerrit change created: https://git.eclipse.org/r/147980 Created attachment 280036 [details]
Screenshot
Benedikt, can this be used to get rid of the uglynes of the MANIFEST.MF editor in the dark theme?
Created attachment 280040 [details]
MANIFEST.MF Editor styled
Added this to e4-dark_win.css:
Section {
swt-titlebar-color: #0000FF;
tb-toggle-color: #00FF00;
tb-toggle-hover-color: #FF0000;
background-color-gradient-titlebar: #00FF00;
background-color-titlebar: #0000FF;
border-color-titlebar: #00FF00;
}
ExpandableComposite {
swt-titlebar-color: #FF0000;
tb-toggle-color: #FF0000;
tb-toggle-hover-color: #00FF00;
}
Result see attachment....
Is this what you meant, Lars?
(In reply to Benedikt Kuntz from comment #6) > Is this what you meant, Lars? Cool. Opened follow-up Bug 551532 to use that in our default themes. Could you provide a Gerrit for that, Benedikt? Gerrit change https://git.eclipse.org/r/147354 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6e663046669162b24bf8f3da91e9cce30d6f2ae6 Thanks, Benedikt. Could you add an entry to the N&N for 4.14? You find the repo here https://git.eclipse.org/r/#/admin/projects/www.eclipse.org/eclipse/news here existing 4.14 entries for examples. New Gerrit change created: https://git.eclipse.org/r/150250 Gerrit change https://git.eclipse.org/r/150250 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=fa40a43d480393c09f79a7654f4c44d77f18ecd4 |