Bug 54927

Summary:

VerticalPlacement should take a flag in it's constructor that determines whether the height of the nodes should be changed

Product:

[Tools] GEF

Reporter:

Sean Woodhouse <swoodhouse>

Component:

GEF-Legacy Draw2d

Assignee:

gef-inbox <gef-inbox>

Status:

NEW ---

QA Contact:

Severity:

enhancement

Priority:

CC:

ahunter.eclipse, vineet

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
source	none

Description Sean Woodhouse

2004-03-15 20:12:48 EST

Currently org.eclipse.draw2d.internal.graph.VerticalPlacement will resize the 
height of the nodes to be the height of the biggest node in the row. This 
behaviour should really selectable. I suggest adding a boolean flag to the 
constructor to enable or disable this behaviour.

Comment 1 Sean Woodhouse

2004-03-15 20:15:26 EST

Created attachment 8591 [details]
source

Comment 2 Randy Hudson

2004-05-01 20:03:22 EDT

This class is currently internal.  What would you propose for an [open-ended] 
set of layout hints on both the Nodes and the DirectedGraph?

Comment 3 Sean Woodhouse

2004-05-02 19:43:54 EDT

I'd suggest adding a mechanism on DirectedGraphLayout.visit() method to 
specify how you want the graph laid out. These could be defined by a 'style' 
flag, or a dictionary of layout directives. The characteristics you can change 
will really be determined by the implementation of the visit() method, so a 
dictionary might be the better implementation. 

You could also apply these directives to each node and edge, but I would 
assume in most cases you'd want the same directives to apply across all nodes 
and edges for a particular layout invocation. Hence my suggestion to put it on 
DirectedGraphLayout.