Bug 548990

Summary: [Quicksearch] Non-modal dialog search context never refreshed
Product: [Eclipse Project] Platform Reporter: Kris De Volder <kdevolder>
Component: TextAssignee: Platform-Text-Inbox <platform-text-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: gautier.desaintmartinlacaze
Version: 4.13   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Kris De Volder CLA 2019-07-04 15:14:41 EDT
Follow up ticket from: https://bugs.eclipse.org/bugs/show_bug.cgi?id=548518

See: 

    https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/core/priority/DefaultPriorityFunction.java@126
    https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/ui/QuickSearchContext.java@44

The search 'context' is created when the dialog is openened. It includes some data, such as for example a computed list of 'ignored' folders which can become stale over time. This is mostly relevant when the dialog is used in 'modeless' form so that it remains open even as the user continues to do other work.

Some mechanism should be added to 'refresh' the context, maybe something based on workspace listenener, or maybe it could be tied to the 'refresh' button that is already present in the dialog, or both. 

Another idea could be to refresh the context every time the dialog receives focus.