Bug 548988

Summary: [Quicksearch] Cleanup mess around quicksearch menu contribution
Product: [Eclipse Project] Platform Reporter: Kris De Volder <kdevolder>
Component: TextAssignee: Platform-Text-Inbox <platform-text-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: gautier.desaintmartinlacaze
Version: 4.13   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Kris De Volder CLA 2019-07-04 15:03:44 EDT
Follow up ticket from: https://bugs.eclipse.org/bugs/show_bug.cgi?id=548518

There's a big mess in quicksearch plugin.xml. It points to a potential issue in the platform (the mess was created in an apparant workaround to add a menu contribution to existing 'Search' menu in the proper way).

It is possible the problem in platform has since been fixed in which case the workaround should be removed. Otherwise, a bug should be raised to fix it in platform (and then the workaround removed).

See: 
https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/plugin.xml@18
https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/ui/QuickSearchAction.java@23