Bug 545450

Summary:	Move common functionality from IGesture implementations to AbstractGesture
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	Matthias Wienand <matthias.wienand>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	5.0.100
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2019-03-15 11:38:46 EDT

Currently, the individual IGesture implementations share some implementation details. In order to de-duplicate the code, we should pull up the common functionality into the AbstractGesture base class.

At least the setup of scene listeners and their initial invocation (as well as final clean-up) can probably be moved to AbstractGesture, i.e. the code currently executed in individual doActivate() and doDeactivate() callbacks.

Comment 1 Matthias Wienand

2019-09-12 15:46:16 EDT

I refactored most of the gestures, except for ScrollGesture and TypeStrokeGesture, which pass special parameters to some methods (a viewer and a set of pressed keys, respectively). These need to be looked at in more detail to refactor appropriately.