Bug 542703

Comment 1 Lars Vogel 2018-12-12 05:33:24 EST

Mickael. WDYT?

Comment 2 Andrey Loskutov 2018-12-12 05:38:04 EST

(In reply to Lars Vogel from comment #0)
> we should always open the wizard in maximized mode.

I would not like this, I've never needed maximized state here. Probably resolution/monitor dependent, but I had always enough space, on both my Linux workstation/Windows notebook.

> Alternatively, we should remember the size and position of the wizard.

This would be fine, but shouldn't this be already there? If not: why? Is this per-wizard?

Comment 3 Mickael Istria 2018-12-12 05:46:41 EST

> If others, like Mickael the creator of this wizard, are doing the same, we should always open the wizard in maximized mode.

I don't think I do that always. I maybe did it once or twice in my life and you were lucky to be there ;)

I'm not sure we should make this wizard behave differently of other ones in general.

Comment 4 Dani Megert 2018-12-12 06:28:26 EST

Also -1 to open maximized. Remembering the size would be OK for me.

Comment 5 Lars Vogel 2018-12-12 06:56:02 EST

(In reply to Andrey Loskutov from comment #2)
 
> This would be fine, but shouldn't this be already there? 

It does not remember its size for me. Does it for you?

Comment 6 Andrey Loskutov 2018-12-12 07:26:37 EST

(In reply to Lars Vogel from comment #5)
> (In reply to Andrey Loskutov from comment #2)
>  
> > This would be fine, but shouldn't this be already there? 
> 
> It does not remember its size for me. Does it for you?

No, I was just surprised (again) that wizards have to do extra work to remember size/location. Sounds like a missing default feature for me. As a wizard user I most likely want the wizard to remember settings / size. 

But I guess this expectation applies to all JFace dialogs (not just wizards), which makes me wonder what was rationale not to do this by default.

Comment 7 Lars Vogel 2020-03-31 08:58:58 EDT

Julian, you fixed various dialogs not remembering their size. Can you take this one too?

Comment 8 Julian Honnen 2020-03-31 09:22:56 EDT

Wizards can't remember any size/bounds - only the WizardDialog could do that.

WizardDialog could implement getDialogBoundsSettings() and return the Wizard's dialog settings (if available). That would
a) affect every Wizard, without any option to opt-out
b) possibly break Wizards, because we stored unexpected contents in
   their settings

Do we want that?

Comment 9 Lars Vogel 2020-03-31 10:55:07 EDT

(In reply to Julian Honnen from comment #8)
> Wizards can't remember any size/bounds - only the WizardDialog could do that.
> 
> WizardDialog could implement getDialogBoundsSettings() and return the
> Wizard's dialog settings (if available). That would
> a) affect every Wizard, without any option to opt-out
> b) possibly break Wizards, because we stored unexpected contents in
>    their settings
> 
> Do we want that?

Could we add API to opt-in?

Comment 10 Julian Honnen 2020-04-01 04:45:30 EDT

(In reply to Julian Honnen from comment #8)
> Wizards can't remember any size/bounds - only the WizardDialog could do that.
> 
> WizardDialog could implement getDialogBoundsSettings() and return the
> Wizard's dialog settings (if available).
On second look, that doesn't work as a generic solution.

A WizardDialog instance may be used for multiple Wizards. Like in the case of the import wizard, which dynamically adds pages from the selected import type.