Bug 542105

Summary:	[test] Rethink JRE filter in ModuleBuilderTests
Product:	[Eclipse Project] JDT	Reporter:	Stephan Herrmann <stephan.herrmann>
Component:	Core	Assignee:	Stephan Herrmann <stephan.herrmann>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	test
Version:	4.10
Target Milestone:	4.11 M1
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=541015 https://git.eclipse.org/r/134694 https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=ca62329fead9ba47ab1cc79d4fce6a2cbd6439dd
Whiteboard:

Description Stephan Herrmann

2018-12-04 15:14:48 EST

Follow-up from bug 541015 comment 9:

ModuleBuilderTests.testBug541015 accidentally runs even on JRE 8-

I would hope there's a simple way to disable the entire suite if !isJRE9.
If that's not possible then the mentioned test needs this check added.

Comment 1 Eclipse Genie

2019-01-06 12:01:36 EST

New Gerrit change created: https://git.eclipse.org/r/134694

Comment 2 Eclipse Genie

2019-01-06 13:35:10 EST

Gerrit change https://git.eclipse.org/r/134694 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=ca62329fead9ba47ab1cc79d4fce6a2cbd6439dd

Comment 3 Stephan Herrmann

2019-01-06 13:36:49 EST

(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/134694 was merged to [master].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?id=ca62329fead9ba47ab1cc79d4fce6a2cbd6439dd

Fix released for 4.11 M1: if (!isJRE9) we simply create an almost empty suite (containing only one test to remind us that tests only run on 9+).

Comment 4 Manoj N Palat

2019-01-08 05:23:54 EST

Verified for Eclipse 4.11 M1 with Build id: I20190107-0600