Bug 541190

Summary:	Generic Editor should support more input sources than files
Product:	[Modeling] ECP	Reporter:	Lucas Koehler <lkoehler>
Component:	EMF Forms	Assignee:	Lucas Koehler <lkoehler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	noteworthy
Version:	unspecified
Target Milestone:	1.22.0
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/146248 https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=d116392793f8c2af152f9bc479ee339857dbffcf https://git.eclipse.org/r/146316 https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=200f04a674d1534eeebc89b01da924482f924b36
Whiteboard:
Bug Depends on:
Bug Blocks:	541191

Description Lucas Koehler

2018-11-15 03:44:47 EST

Currently, the GenericEditor only works correctly with FileEditorInputs. This means only files present as a file in the workspace can be opened.
The GenericEditor should also support other inputs such as IStorageEditorInput and especially FileRevisionEditorInput which is used when opening files from the history.

Comment 1 Eclipse Genie

2019-07-17 10:19:30 EDT

New Gerrit change created: https://git.eclipse.org/r/146248

Comment 2 Eclipse Genie

2019-07-17 17:20:44 EDT

Gerrit change https://git.eclipse.org/r/146248 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=d116392793f8c2af152f9bc479ee339857dbffcf

Comment 3 Eclipse Genie

2019-07-18 08:09:40 EDT

New Gerrit change created: https://git.eclipse.org/r/146316

Comment 4 Eclipse Genie

2019-07-18 12:11:55 EDT

Gerrit change https://git.eclipse.org/r/146316 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=200f04a674d1534eeebc89b01da924482f924b36

Comment 5 Lucas Koehler

2019-07-22 08:16:03 EDT

The Generic Editor can now load files from a storage input as readonly. Concretely, this allows to view older revisions of files from Eclipse's local history or a Git history via EGit.