Bug 539524

Summary: [GTK4] Port event handling to GtkEventController
Product: [Eclipse Project] Platform Reporter: Eric Williams <ericwill>
Component: SWTAssignee: Platform-SWT-Inbox <platform-swt-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: gautier.desaintmartinlacaze, jmajano
Version: 4.23Keywords: triaged
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/130369
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7e252e3b676538e66261bfe18cb6922e90f192bd
https://git.eclipse.org/r/135264
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ce2d380a4f6ab3facf81919f1e2546655ef70e7f
https://git.eclipse.org/r/135342
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4c6f9b48145b05e0fa1ba1ca2d72508f386576b0
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183027
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=956c7d6f207ebc12715f8dde298e58af6d33aa22
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183457
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183706
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=b70cd16c42914b617e770ad76a8e951fa6ebf325
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4ff9f1c7ce18ead311d01f49f210864266dbae88
Whiteboard: RHT
Bug Depends on:    
Bug Blocks: 540385    

Description Eric Williams CLA 2018-09-26 14:10:04 EDT
Port SWT's event handling to GtkEventController in preparation for GTK4.
Comment 1 Eric Williams CLA 2018-10-03 14:33:51 EDT
I have had some basic success with a text widget and the "key-pressed" signal. 

However some widgets like Button aren't playing nicely, even at the native level. I've opened an issue against GTK for this: https://gitlab.gnome.org/GNOME/gtk/issues/1379
Comment 2 Eclipse Genie CLA 2018-10-03 16:49:49 EDT
New Gerrit change created: https://git.eclipse.org/r/130369
Comment 4 Eclipse Genie CLA 2019-01-17 11:44:33 EST
New Gerrit change created: https://git.eclipse.org/r/135264
Comment 6 Eclipse Genie CLA 2019-01-18 12:12:00 EST
New Gerrit change created: https://git.eclipse.org/r/135342
Comment 8 Eric Williams CLA 2019-01-23 14:58:35 EST
Some things to note for GTK4 events:

-Enter/leave is not handled properly on the native side, and will be subject to change in the future. For now however this will lead to broken behaviour.

-It will probably be useful to maintain some sort of global controller registry to avoid having redundant controllers for a widget. This can be done later down the road when events are working 100% and can be tested
Comment 9 Eric Williams CLA 2019-03-20 14:33:34 EDT
This isn't in a working state for 3.24, so I'm moving it to be GTK4 only.
Comment 10 Eric Williams CLA 2019-12-16 14:55:27 EST
I think upstream GTK4 development has made some good progress on event handling. Whoever works on this in the future should confirm the status of comment 8.
Comment 11 Eclipse Genie CLA 2021-07-13 11:38:02 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183027
Comment 13 Eclipse Genie CLA 2021-07-28 15:35:31 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183457
Comment 16 Joel Majano CLA 2021-11-26 15:59:10 EST
Signal handling is an ongoing process, not all signals have been converted to GtkEventController.