Bug 536246

Summary:	View Templates should allow to register more than one template
Product:	[Modeling] ECP	Reporter:	Eugen Neufeld <eneufeld>
Component:	EMF Forms	Assignee:	Lucas Koehler <lkoehler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	lkoehler
Version:	unspecified	Keywords:	test
Target Milestone:	1.18.0
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/125651 https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=b6f58b5614a75141f8ec91cf6d334f02207f81c3
Whiteboard:

Description Eugen Neufeld

2018-06-25 08:27:26 EDT

The ViewTemplates should be refactored to be osgi service based instead of relying on the implementation.
Furthermore the xmi template provider should be changed to support more than one file being registered at once.

Comment 1 Eclipse Genie

2018-07-05 12:30:07 EDT

New Gerrit change created: https://git.eclipse.org/r/125651

Comment 2 Lucas Koehler

2018-07-10 05:13:37 EDT

TEST INFORMATION

Summary of the critical part of the change
The ViewTemplateSupplier can now process multiple view templates that are supplied by instances of the newly defined ViewTemplateSupplier. The ViewTemplateSupplierImpl now reads in the same extension point as the old ViewTemplateProviderImpl. Thereby, it can also read in multiple view models.
In case there is more than one view template, ViewTemplateProviderImpl.getViewTemplate returns a "merged" view template of all supplied view templates. Thereby, only one control validation template can be used.

Potential regressions
The ViewModelProvider.getViewTemplate and .hasControlValidationTemplate methods are now deprecated. This can lead to additional warnings in custom implementations.

Affected areas / use cases
Styling of views with view templates.

Things that shall be tested
That existing view templates are still correctly applied.

Comment 3 Eclipse Genie

2018-07-10 05:55:52 EDT

Gerrit change https://git.eclipse.org/r/125651 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=b6f58b5614a75141f8ec91cf6d334f02207f81c3