Bug 534314

Summary:	[code mining] Line numbering and collapse/expand aligned with code lines
Product:	[Eclipse Project] Platform	Reporter:	Angelo ZERR <azerr>
Component:	Text	Assignee:	Platform-Text-Inbox <platform-text-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	Lars.Vogel, mistria
Version:	4.8
Target Milestone:	4.8 M7
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/122101 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=db8a856dcb8e363ce2ebe4c068189743d90c2533
Whiteboard:
Bug Depends on:	531769
Bug Blocks:

Description Angelo ZERR

2018-05-03 08:50:54 EDT

It would be nice to have line numbers and collapse/expand icons aligned with the "real code", so the user can immediately understand where is "real code", and where is "meta-information" looking at the ruler on the left side.

Currently, the line number and the collapse/expand icon are vertically aligned in the middle of the area contanining both code and meta-annotation.

See the problem explained at https://github.com/angelozerr/jdt-codemining/issues/13

Comment 1 Mickael Istria

2018-05-03 08:53:40 EDT

It's actually a bit hard as there is no clear definition of what is "real code" with the taken approach of glyph metrics. It's again a dep on bug 531769 which is a core missing concept.

Comment 2 Eclipse Genie

2018-05-03 08:54:17 EDT

New Gerrit change created: https://git.eclipse.org/r/122101

Comment 3 Angelo ZERR

2018-05-03 08:55:17 EDT

> It's actually a bit hard as there is no clear definition of what is "real code" with the taken approach of glyph metrics.

Please see  https://git.eclipse.org/r/122101

Comment 4 Eclipse Genie

2018-05-03 09:36:36 EDT

Gerrit change https://git.eclipse.org/r/122101 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=db8a856dcb8e363ce2ebe4c068189743d90c2533

Comment 5 Angelo ZERR

2018-05-03 09:42:45 EDT

Thank a lot @Mickael!