Bugzilla – Full Text Bug Listing
| Summary: | [10] Switch ASTs to JLS_Latest | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Andrey Loskutov <loskutov> |
| Component: | Debug | Assignee: | JDT-Debug-Inbox <jdt-debug-inbox> |
| Status: | ASSIGNED --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | akurtakov, Lars.Vogel, sarika.sinha |
| Version: | 4.8 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/120504 https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179076 https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077 https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/120504 |
||
| Whiteboard: | stalebug | ||
|
Description
Andrey Loskutov
@Sarika: shouldn't this go to 4.7.3a too? New Gerrit change created: https://git.eclipse.org/r/120504 (In reply to Andrey Loskutov from comment #1) > @Sarika: shouldn't this go to 4.7.3a too? Will let it go in 4.8 only. JLS8 ones should be changed to 10 but we need to be careful for the ones which are having JLS4. (In reply to Sarika Sinha from comment #3) > JLS8 ones should be changed to 10 but we need to be careful for the ones > which are having JLS4. Sarika, can you give some details why places with JLS4 should be differently handled? (In reply to Andrey Loskutov from comment #4) > (In reply to Sarika Sinha from comment #3) > > JLS8 ones should be changed to 10 but we need to be careful for the ones > > which are having JLS4. > > Sarika, can you give some details why places with JLS4 should be differently > handled? Because we have not upgraded it like other places. I am not aware of the history why they were not changed like other places. Is this missing 4.9 ? We can switch to JLS 11 in 4.10 M1. Could not find time in 4.12 Looks like JDT provides JLS_Latest these days in org.eclipse.jdt.core.dom.AST Sarika, can we switch to that constant? (In reply to Lars Vogel from comment #9) > Looks like JDT provides JLS_Latest these days in org.eclipse.jdt.core.dom.AST > > Sarika, can we switch to that constant? Yes we can. New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179076 New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077 (In reply to Eclipse Genie from comment #12) > New Gerrit change created: > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077 Can we please have it in 1 gerrit? (In reply to Sarika Sinha from comment #13) > (In reply to Eclipse Genie from comment #12) > > New Gerrit change created: > > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077 > > Can we please have it in 1 gerrit? So the change in the test code is also fine? (In reply to Lars Vogel from comment #14) > (In reply to Sarika Sinha from comment #13) > > (In reply to Eclipse Genie from comment #12) > > > New Gerrit change created: > > > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077 > > > > Can we please have it in 1 gerrit? > > So the change in the test code is also fine? I have not looked at this test, but in general, unless a test is testing some special feature from a particular Java version we can update it to latest. (In reply to Sarika Sinha from comment #15) > > > Can we please have it in 1 gerrit? Merged with previous Gerrit, https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179076 This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |