Bug 532756

Summary:	Check ContainerSWTRenderer Constructor
Product:	[Modeling] ECP	Reporter:	Eugen Neufeld <eneufeld>
Component:	EMF Forms	Assignee:	Jonas Helming <jhelming>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P5	Keywords:	test
Version:	unspecified
Target Milestone:	1.20.0
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/133193 https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=80ce2420136045a77742f0099287b0361d24693b
Whiteboard:

Description Eugen Neufeld

2018-03-22 07:54:11 EDT

The containerswtrenderer costructor expects EMFFormsDatabinding and EMFFormsRendererFactory.
We should check whether this is needed as they can be retrieved from the ViewModelContext.
Also check all classes extending the containerswtrenderer

Comment 1 Eugen Neufeld

2018-08-22 09:35:47 EDT

Mass Move due to time constraints

Comment 2 Eugen Neufeld

2018-11-06 04:40:59 EST

Mass move to 1.20 due to time constraints.

Comment 3 Jonas Helming

2018-11-28 11:36:47 EST

factory is need, but databinding is superflouous

Comment 4 Jonas Helming

2018-11-28 11:37:55 EST

Testing information:
This changes the API of the containerrenderer. You do not need the databinding parameter anymore, but you can also not retrieve it. If you require a databinding in a subclass, just directly get it injected instead

Comment 5 Eclipse Genie

2018-11-28 11:39:11 EST

New Gerrit change created: https://git.eclipse.org/r/133193

Comment 6 Eclipse Genie

2019-02-04 06:13:16 EST

Gerrit change https://git.eclipse.org/r/133193 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=80ce2420136045a77742f0099287b0361d24693b