Bugzilla – Full Text Bug Listing
| Summary: | [Dark Theme] Adjust dark theme with styling for the range indicator preference from Bug 514043 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||
| Component: | UI | Assignee: | Matthias Becker <ma.becker> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | Lars.Vogel | ||||||
| Version: | 3.7.1 | Keywords: | noteworthy | ||||||
| Target Milestone: | 4.8 M6 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: |
https://git.eclipse.org/r/117242 https://git.eclipse.org/r/117253 https://git.eclipse.org/c/platform/eclipse.git/commit/?id=6179a690915e28309dd3849a894e0d0e64f7705a https://git.eclipse.org/c/www.git/commit/?id=88473563e91e94c1692ca9eb721f780fc877b7b8 |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 514043 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Lars Vogel
Matthias, can you take this one? will look into this once the range indicator color is configurable should the styling be: 1) added to /org.eclipse.ui.themes/css/dark/e4-dark_preferencestyle.css or 2) added to a new css in org.eclipse.ui.workbench.texteditor where the color is defined and stored? New Gerrit change created: https://git.eclipse.org/r/117242 Created attachment 272656 [details]
range indicator in dark theme before change
Created attachment 272657 [details]
range indicator in dark theme after change
What do you think about the color of the range indicator in the dark theme.
I am open to other proposals. I looked around how VScode or IntelliJ does it. But they don't have colored range-indicator as eclipse has.
(In reply to Matthias Becker from comment #6) > Created attachment 272657 [details] > range indicator in dark theme after change > > What do you think about the color of the range indicator in the dark theme. > I am open to other proposals. I looked around how VScode or IntelliJ does > it. But they don't have colored range-indicator as eclipse has. +1 looks awesome to me. New Gerrit change created: https://git.eclipse.org/r/117253 Gerrit change https://git.eclipse.org/r/117242 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.git/commit/?id=6179a690915e28309dd3849a894e0d0e64f7705a Gerrit change https://git.eclipse.org/r/117253 was merged to [master]. Commit: http://git.eclipse.org/c/www.git/commit/?id=88473563e91e94c1692ca9eb721f780fc877b7b8 |