Bug 530996

Summary: Snippets view broken due to changes made in findMouseEventTargetInDescendantsAt()
Product: [Tools] GEF Reporter: John Collier <jcollier>
Component: GEF-Legacy Draw2dAssignee: gef-inbox <gef-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: jwsnyder, nyssen, thatnitind
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
See Also: https://github.com/eclipse/gef-legacy/pull/1
Whiteboard:
Attachments:
Description Flags
minimal palette viewer in a view to show breakage none

Description John Collier CLA 2018-02-10 18:13:10 EST 
Due to changes made to the function findMouseEventTargetInDescendantsAt() in Figures.java for Bug 472848, the Snippets view in Eclipse is broken as of Mars.1. 

When there are multiple folders of snippets, if a user tries to select a snippet that isn't in the first folder / row, the folder will collapse and open the first folder, making it very difficult to properly select the snippet. As a result, I believe this change should be reverted so that the Snippets view can function properly

See Bug 486925 for more details.
Comment 1 Eclipse Genie CLA 2018-02-10 18:19:31 EST 
GitHub Pull Request 1 created by [johnmcollier]
https://github.com/eclipse/gef-legacy/pull/1
Comment 2 Alexander Nyßen CLA 2018-02-11 14:09:12 EST 
The fix to bug #486925 seems to be valid, as it ensures that findMouseEventTargetInDescendantsAt() behaves according to the contract stated in its javadoc. It didn't do that before.

I would thus assume that the mentioned snippet view relies on the previously incorrect behavior. Rather than reverting the change, I would propose to investigate how the snippet view can be adjusted to properly follow the contract.
Comment 3 Nitin Dahyabhai CLA 2018-04-17 17:47:38 EDT 
Created attachment 273659 [details]
minimal palette viewer in a view to show breakage