Bug 527846

Summary:	"Export as Image" dialog should be defined outside of the core.
Product:	[Modeling] Sirius	Reporter:	Jessy Mallet <jessy.mallet>
Component:	Core	Assignee:	Project inbox <sirius.core-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	julien.dupont, laurent.redor
Version:	unspecified	Keywords:	triaged
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Jessy Mallet

2017-11-28 03:44:55 EST

The "Export as Image" dialog is defined in the core org.eclipse.sirius.ui plug-in, so it can not access to the SiriusDiagramUiPreferencesKeys stored in org.eclipse.sirius.diagram.ui.

These preferences impact the initialization of export dialog (for example PREF_SCALE_DIAGRAMS_ON_EXPORT preference).
So the "Export as Image" dialog must not be defined org.eclipse.sirius.ui but rather in org.eclipse.sirius.diagram.ui.

For now, to bypassing this constraint, we use the IDialogSetting to tell it the value of the preference (see org.eclipse.sirius.diagram.ui.provider.DiagramUIPlugin class) but if default value are overridden, the new value is not propagate to the export dialog via the change listener.