Bugzilla – Full Text Bug Listing
| Summary: | TVT1: Hardcoded strings in NewTeamStreamWizard extension | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dan Kehn <kehn> | ||||
| Component: | Team | Assignee: | James Moody <James_Moody> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | camle, scottf | ||||
| Version: | 1.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 2000 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Fixed in v207 Created attachment 63 [details]
Another New CVSWizard hardcode picture
The attached picture is NOT a vcm problem. The string is properly externalized in the 1.0 release. Recommend you check the message catalogs. (vcmui_cvs.jar, file WorkbenchCVSPluginResources.properties, key: NewRepositoryWizard.description=Remember the location of an existing CVS repository.) No action taken. I just looked a second time. I even unzipped the 1.0 code again, just to be
certain. And as you said, the property is indeed correctly defined, HOWEVER
the problem is that it isn't being referenced in the
org.eclipse.vcm.ui.cvs\plugin.xml file. The <description> clause is hardcoded.
Here is the portion of org.eclipse.vcm.ui.cvs\plugin.xml that is incorrect (see
the text in the <description> clause):
<extension
point = "org.eclipse.ui.newWizards">
<category
id="org.eclipse.vcm.ui.cvs"
name="CVS">
</category>
<wizard
id="org.eclipse.vcm.ui.cvs.wizards.new.repository"
name="%NewRepositoryWizard.name"
class="org.eclipse.vcm.internal.ui.ccvs.NewRepositoryWizard"
category="org.eclipse.vcm.ui.cvs"
icon="icons/full/wizards/newconnect_wiz.gif">
<description>Remember the location of an existing CVS
repository.</description>
</wizard>
<wizard
id="org.eclipse.vcm.ui.wizards.new.teamstream"
name="%NewTeamStreamWizard.name"
class="org.eclipse.vcm.internal.ui.wizards.NewTeamStreamWizard"
category="org.eclipse.vcm.ui.cvs"
icon="icons/full/wizards/newstream_wiz.gif">
<description>Create a new stream (CVS branch).</description>
</wizard>
</extension>
Hope this clarifies the cause of the problem.
As far as I can tell, this is the same as the original reported problem. I thought the attached JPG was supposed to indicate a second problem, but it seems to be the same as the original problem. Closing PR again. This bug was fixed in build 207. If there is a different translation bug, please open a separate bug report. OK. It was your comment "The string is properly externalized in the 1.0 release" that misled me. More precisely, it was externalized -- but not properly referenced in the plugin.xml file. I think that Scott added the picture to clarify; there is not a second problem. Sorry for the confusion. Marked as to be fixed for R1, per agreement with TVT testers for NL signoff. |
To reproduce: 1. File > New > Other... 2. Select CVS and Stream 3. Hardcoded string in description below "Select" heading. Proposed modification to org.eclipse.vcm.ui.cvs\plugin.xml: <!-- ******************* WIZARDS ******************* --> <extension point = "org.eclipse.ui.newWizards"> <category id="org.eclipse.vcm.ui.cvs" name="CVS"> </category> <wizard id="org.eclipse.vcm.ui.cvs.wizards.new.repository" name="%NewRepositoryWizard.name" class="org.eclipse.vcm.internal.ui.ccvs.NewRepositoryWizard" category="org.eclipse.vcm.ui.cvs" icon="icons/full/wizards/newconnect_wiz.gif"> <description>%NewRepositoryWizard.description</description> </wizard> <wizard id="org.eclipse.vcm.ui.wizards.new.teamstream" name="%NewTeamStreamWizard.name" class="org.eclipse.vcm.internal.ui.wizards.NewTeamStreamWizard" category="org.eclipse.vcm.ui.cvs" icon="icons/full/wizards/newstream_wiz.gif"> <description>%NewTeamStreamWizard.description</description> </wizard> </extension> Proposed additions to org.eclipse.vcm.ui.cvs\plugin.properties: NewTeamStreamWizard.description = ... NewRepositoryWizard.description = ...