Bug 5266 - TVT1: Hardcoded strings in NewTeamStreamWizard extension
Summary: TVT1: Hardcoded strings in NewTeamStreamWizard extension
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: James Moody CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-25 18:49 EDT by Dan Kehn CLA
Modified: 2001-11-08 14:26 EST (History)
2 users (show)

See Also:


Attachments
Another New CVSWizard hardcode picture (192.18 KB, image/jpeg)
2001-11-02 16:10 EST, Scott Fairbrother CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Kehn CLA 2001-10-25 18:49:05 EDT
To reproduce:

1. File > New > Other...
2. Select CVS and Stream
3. Hardcoded string in description below "Select" heading.

Proposed modification to org.eclipse.vcm.ui.cvs\plugin.xml:

<!-- ******************* WIZARDS ******************* -->
   <extension
	point = "org.eclipse.ui.newWizards">
	<category
	   id="org.eclipse.vcm.ui.cvs"
	   name="CVS">
	</category>
	<wizard 
	   id="org.eclipse.vcm.ui.cvs.wizards.new.repository"
	   name="%NewRepositoryWizard.name"
	   class="org.eclipse.vcm.internal.ui.ccvs.NewRepositoryWizard"
	   category="org.eclipse.vcm.ui.cvs"
	   icon="icons/full/wizards/newconnect_wiz.gif">
           <description>%NewRepositoryWizard.description</description>
    </wizard>
	<wizard 
	   id="org.eclipse.vcm.ui.wizards.new.teamstream"
	   name="%NewTeamStreamWizard.name"
	   class="org.eclipse.vcm.internal.ui.wizards.NewTeamStreamWizard"
	   category="org.eclipse.vcm.ui.cvs"
	   icon="icons/full/wizards/newstream_wiz.gif">
           <description>%NewTeamStreamWizard.description</description>
    </wizard>
   </extension>

Proposed additions to org.eclipse.vcm.ui.cvs\plugin.properties:

NewTeamStreamWizard.description = ...
NewRepositoryWizard.description = ...
Comment 1 James Moody CLA 2001-10-26 14:08:19 EDT
Fixed in v207
Comment 2 Scott Fairbrother CLA 2001-11-02 16:10:39 EST
Created attachment 63 [details]
Another New CVSWizard hardcode picture
Comment 3 James Moody CLA 2001-11-02 16:24:33 EST
The attached picture is NOT a vcm problem. The string is properly externalized 
in the 1.0 release. Recommend you check the message catalogs.
(vcmui_cvs.jar, file WorkbenchCVSPluginResources.properties, key:
NewRepositoryWizard.description=Remember the location of an existing CVS 
repository.)

No action taken.
Comment 4 Dan Kehn CLA 2001-11-02 17:31:00 EST
I just looked a second time.  I even unzipped the 1.0 code again, just to be 
certain.  And as you said, the property is indeed correctly defined, HOWEVER 
the problem is that it isn't being referenced in the 
org.eclipse.vcm.ui.cvs\plugin.xml file.  The <description> clause is hardcoded.

Here is the portion of org.eclipse.vcm.ui.cvs\plugin.xml that is incorrect (see 
the text in the <description> clause):

   <extension
	point = "org.eclipse.ui.newWizards">
	<category
	   id="org.eclipse.vcm.ui.cvs"
	   name="CVS">
	</category>
	<wizard 
	   id="org.eclipse.vcm.ui.cvs.wizards.new.repository"
	   name="%NewRepositoryWizard.name"
	   class="org.eclipse.vcm.internal.ui.ccvs.NewRepositoryWizard"
	   category="org.eclipse.vcm.ui.cvs"
	   icon="icons/full/wizards/newconnect_wiz.gif">
           <description>Remember the location of an existing CVS 
repository.</description>
    </wizard>
	<wizard 
	   id="org.eclipse.vcm.ui.wizards.new.teamstream"
	   name="%NewTeamStreamWizard.name"
	   class="org.eclipse.vcm.internal.ui.wizards.NewTeamStreamWizard"
	   category="org.eclipse.vcm.ui.cvs"
	   icon="icons/full/wizards/newstream_wiz.gif">
           <description>Create a new stream (CVS branch).</description>
    </wizard>
   </extension>

Hope this clarifies the cause of the problem.
Comment 5 James Moody CLA 2001-11-06 11:20:37 EST
As far as I can tell, this is the same as the original reported problem. I 
thought the attached JPG was supposed to indicate a second problem, but it 
seems to be the same as the original problem. Closing PR again. This bug was 
fixed in build 207. If there is a different translation bug, please open a 
separate bug report.
Comment 6 Dan Kehn CLA 2001-11-06 11:56:49 EST
OK.  It was your comment "The string is properly externalized in the 1.0 
release" that misled me.  More precisely, it was externalized -- but not 
properly referenced in the plugin.xml file.

I think that Scott added the picture to clarify; there is not a second 
problem.  Sorry for the confusion.
Comment 7 Dan Kehn CLA 2001-11-08 14:26:23 EST
Marked as to be fixed for R1, per agreement with TVT testers for NL signoff.