Bugzilla – Full Text Bug Listing
| Summary: | Open resource should use highlight matches based on substrings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||
| Component: | UI | Assignee: | Christoph Stanik <stanik> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | david.eclipse000, fabian.pfaff, Lars.Vogel, ocroquette, psuzzi, reckord, register.eclipse, stanik | ||||||
| Version: | 4.3 | Keywords: | bugday, helpwanted, noteworthy, usability | ||||||
| Target Milestone: | 4.8 M1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: |
https://git.eclipse.org/r/101370 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=131c5e405cd7923cc7c3177c46fa2a473f059290 https://git.eclipse.org/r/101879 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3d763c5c1f21f5de2806fd45bba976b9e565875c |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 520250, 520251 | ||||||||
| Attachments: |
|
||||||||
Created attachment 269319 [details]
Screenshot Open Resource
Gerrit patches are welcome New Gerrit change created: https://git.eclipse.org/r/101370 Gerrit change https://git.eclipse.org/r/101370 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=131c5e405cd7923cc7c3177c46fa2a473f059290 Thanks, Christoph, looks very good to me and this is extremely useful. New Gerrit change created: https://git.eclipse.org/r/101879 Gerrit change https://git.eclipse.org/r/101879 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3d763c5c1f21f5de2806fd45bba976b9e565875c Thanks for working on this. Only substring matches are implemented, the following cases are missing (which are the cases when highlighting would be most useful): - CamelCase. - Patterns (like prefix*moretext) In "Open Type", all matching kinds are handled correctly. I'm setting the status to REOPENED so this doesn't get overlooked, because I really think this should either be completely implemented or reverted as in the current state, this feels very broken. (In reply to Till Brychcy from comment #8) > Thanks for working on this. > > I'm setting the status to REOPENED so this doesn't get overlooked, because I > really think this should either be completely implemented or reverted as in > the current state, this feels very broken. I suggest to handle this via a new bug, substring matching is IMHO already useful. (In reply to Lars Vogel from comment #9) > I suggest to handle this via a new bug, substring matching is IMHO already > useful. I adjusted the bug message header to reflect the actual work and will open new two news bugs for the other highlighting options. |
Created attachment 269318 [details] Screenshot from Open Type Open Type uses styles to highlight the matching Java class. Open resources should use the same. g