Bug 516715

Summary:	org.eclipse.ui.genericeditor.tests must not influence normal runtime workbench
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	Text	Assignee:	Mickael Istria <mistria>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	daniel_megert
Version:	4.7	Keywords:	test
Target Milestone:	4.7 RC1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/97222 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=58fb05181030ab9105edb1d26f36f206f74ab4dc
Whiteboard:

Description Markus Keller

2017-05-16 07:46:12 EDT

A rule for sane test bundles is that they must not screw a normal runtime workbench. I.e. when you launch with the test bundle enabled, there should not be any visible damage. Until recently, Platform Text was in the "sane" category (unlike the horribly breaking Platform UI tests).

org.eclipse.ui.genericeditor.tests contributes an unconditional hover provider "MagicHoverProvider" that makes all generic editors in a runtime workbench show a hover with text "Alrighty!". This contribution needs to be disabled by default. It must only be enabled while the test that needs it is running.

Also make a pass over other globally contributed behavior and make sure it behaves.

Comment 1 Markus Keller

2017-05-16 07:47:16 EDT

Assigning to 4.8. Feel free to fix this in 4.7 up to RC3.

Comment 2 Mickael Istria

2017-05-16 07:50:43 EDT

I'll do it today, it should be hard as the generic editor extensions already allow filtering by content type.

Comment 3 Eclipse Genie

2017-05-16 08:30:39 EDT

New Gerrit change created: https://git.eclipse.org/r/97222

Comment 4 Eclipse Genie

2017-05-16 08:42:46 EDT

Gerrit change https://git.eclipse.org/r/97222 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=58fb05181030ab9105edb1d26f36f206f74ab4dc

Comment 5 Mickael Istria

2017-05-16 08:43:02 EDT

Thanks for the remind Markus.