Bug 516534

Summary:	Remove unnecessary dependency to org.eclipse.ui.tests.harness from org.eclipse.ui.genericeditor.tests
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	Text	Assignee:	Lars Vogel <Lars.Vogel>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel, mistria
Version:	4.4	Keywords:	test
Target Milestone:	4.7 RC1
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/96891 https://bugs.eclipse.org/bugs/show_bug.cgi?id=513399 https://bugs.eclipse.org/bugs/show_bug.cgi?id=511101 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=f644806f15ee3e28a293a875b2673014d4ff26bd
Whiteboard:

Description Lars Vogel

2017-05-11 16:02:42 EDT

org.eclipse.ui.tests.harness seems unused in org.eclipse.ui.genericeditor.tests.

Comment 1 Eclipse Genie

2017-05-11 16:03:10 EDT

New Gerrit change created: https://git.eclipse.org/r/96891

Comment 2 Mickael Istria

2017-05-12 01:39:38 EDT

Actually, the issue is more that org.eclipse.ui.tests.harness DisplayHelper should be fixed and reused in the org.eclipse.ui.genericeditor.tests. See bug 513399

Comment 3 Lars Vogel

2017-05-12 02:00:27 EDT

(In reply to Mickael Istria from comment #2)
> Actually, the issue is more that org.eclipse.ui.tests.harness DisplayHelper
> should be fixed and reused in the org.eclipse.ui.genericeditor.tests. See
> bug 513399

If I understood Markus correctly, he does not want to depend on platform UI code in text. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=511101#c9

Comment 4 Dani Megert

2017-05-12 04:20:59 EDT

(In reply to Lars Vogel from comment #3)
> If I understood Markus correctly, he does not want to depend on platform UI
> code in text. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=511101#c9

+1 to that.

Comment 5 Eclipse Genie

2017-05-15 09:25:43 EDT

Gerrit change https://git.eclipse.org/r/96891 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=f644806f15ee3e28a293a875b2673014d4ff26bd

Comment 6 Mickael Istria

2017-05-15 09:26:18 EDT

Thanks Lars.

Comment 7 Lars Vogel

2017-05-29 14:49:59 EDT

commit looks fine.