Bug 510243

Summary:	Improve properties view toolbar actions
Product:	[Modeling] Sirius	Reporter:	Stephane Begaudeau <stephane.begaudeau>
Component:	Properties	Assignee:	Project Inbox <sirius.properties-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	axel.richard, pierre-charles.david
Version:	4.1.1	Keywords:	triaged
Target Milestone:	---
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/88617 https://git.eclipse.org/r/88618
Whiteboard:

Description Stephane Begaudeau

2017-01-11 05:19:38 EST

Add support for:
* tooltipExpression
* hoverImageExpression
* sub-actions

Comment 1 Axel RICHARD

2017-01-11 05:41:49 EST

The tooltipExpression is already handled by https://bugs.eclipse.org/bugs/show_bug.cgi?id=496076

Comment 2 Axel RICHARD

2017-01-11 09:26:00 EST

The hoverImageExpression can't be handled correctly.
Indeed, with the default implementation of org.eclipse.jface.action.ActionContributionItem, the private method boolean updateImage(boolean forceImage) if the hoverImageDescriptor is set, then it is taken as the image in place of the imageDescriptor.
See boolean org.eclipse.jface.action.ActionContributionItem.updateImages(boolean forceImage) fore more details.

Comment 3 Eclipse Genie

2017-01-13 04:07:11 EST

New Gerrit change created: https://git.eclipse.org/r/88617

Comment 4 Eclipse Genie

2017-01-13 04:07:23 EST

New Gerrit change created: https://git.eclipse.org/r/88618

Comment 5 Pierre-Charles David

2017-03-22 04:35:34 EDT

Moving to 5.1 as this is not essential for 5.0. If this is fixed for 5.0, fine, but it's not blocking for 5.0.