Bugzilla – Full Text Bug Listing
| Summary: | DOT Graph View - Dot2ZestAttributesConverter needs to properly handle EscString values | ||
|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Alexander Nyßen <nyssen> |
| Component: | GEF DOT | Assignee: | gef-inbox <gef-inbox> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | eclipse, miklossy |
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 507413 | ||
| Bug Blocks: | |||
|
Description
Alexander Nyßen
Updating this bug, we should note that there was a discussion on which of such strings to replace and where to replace them in bug #508830. Furthermore, we introduced all EscString values other than proper EscString newline support, as far as I can see, in bug #534707 - sorry for not noticing this bug at the time... What thus remains to be introduced in Dot Graph View is newline justification and hence "\l", "\r" escape sequences. I pushed a commit with the following changes to the master branch: [508868] Adapt linebreak decode to also honour "\l" and "\r" -adapt decodeLineBreak method in Dot2ZestAttributeConverter to also convert "\r" and "\l" linebreaks -disregard final linebreak character (signifies line orientation only) -does not offer full linebreak support, as we currently do not honour implied justification setting As mentioned, there is not yet support for line justification based on EscString newline sequences. We had hence not yet implemented this (I changed the TODO appropriately). However, wrongly justified text seems better than to not handle the newline escape sequences at all. Correct justification however, requires changes in Zest, as the JavaFX Text class does not allow seperate styles for each line/paragraph. Leaving the bug open. |