Bug 507411

Summary:	[Preferences] support for "dirtiness" on preference pages
Product:	[Eclipse Project] Platform	Reporter:	Mickael Istria <mistria>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, gautier.desaintmartinlacaze, Lars.Vogel, psuzzi
Version:	4.6	Keywords:	needinfo
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	497428

Description Mickael Istria

2016-11-11 11:29:37 EST

For a given preference page, it's not visible if something was modified and required to be applied/saved to be taken into account. The "Apply" buttons only obeys to page validity state, not to page "dirtiness".
A user clicking Cancel on a wizard cannot be informed of whether some of their change require to be applied first.

Comment 1 Patrik Suzzi

2016-11-12 11:34:51 EST

IIUC, we should enable the Apply button only if the inputs are changed. Correct?

Could you please make an example we can use as a test case?

Thanks!

Comment 2 Mickael Istria

2016-11-20 09:21:59 EST

(In reply to Patrik Suzzi from comment #1)
> IIUC, we should enable the Apply button only if the inputs are changed.
> Correct?

The issue is much deeper: on a given preference page, there is no generic way to know whether the input changed and whether to change state of apply button. Each page is expected to do it individually, but it's actually often just kept enabled.