Summary: | Incorrect and inconsistent rendering of disabled images | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Felix Hirsch <felix.hirsch> | ||||||||
Component: | SWT | Assignee: | Platform-SWT-Inbox <platform-swt-inbox> | ||||||||
Status: | NEW --- | QA Contact: | |||||||||
Severity: | normal | ||||||||||
Priority: | P3 | CC: | ahmet.bilgin.mail, digga1404, felix.hirsch, gautier.desaintmartinlacaze, Lars.Vogel, lukas.kirchhart, nikita, simon.scholz | ||||||||
Version: | 4.6 | ||||||||||
Target Milestone: | --- | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Whiteboard: | |||||||||||
Attachments: |
|
Description
Felix Hirsch
2016-10-17 05:31:27 EDT
Created attachment 264891 [details]
Example to create disabled images
Run the application from within the eclipse ide since it uses resources from org.eclipse.ui
There is a relationship to #302918. This bug is also about the misbehaviour of ToolItem#setDisabledImage under Linux. Sorry Felix for never replying to your bug report. Can you still observe these bad rendering in the lastest 2020-09 release? If yes, could you create Gerrits for suggested improvements? Hi Lars, thanks for the answer. I can run the test again with the latest release, but as far as I searched online, I can only find a download of 2020-06 RC1. Did you mean this version or can you explain me where I get a copy of a 2020-09 milestone? Thanks (In reply to Felix Hirsch from comment #4) > Hi Lars, > > thanks for the answer. I can run the test again with the latest release, but > as far as I searched online, I can only find a download of 2020-06 RC1. > > Did you mean this version or can you explain me where I get a copy of a > 2020-09 milestone? > > Thanks Hi Felix, https://download.eclipse.org/eclipse/downloads/ has the latest I-Build. Created attachment 283290 [details]
Disabled images in Eclipse 2020-09 I20200610-1800
The behavior changed a little bit, but IMHO it is still not good.
Implicitly (automatic) rendering of disabled images on Windows 10 looks still bad, as I see it.
Explicit rendering of ToolItem-images on Linux now at least uses the provided disabled images but the system changes them (they are slightly brighter than the provided ones). Nevertheless the look of most implicitly disabled images differ from the style of the disabled images which are provided explicitly (See in the provided attachment).
And I wonder why the style guide convention of providing explicitly disabled images counts only for ToolItems? Disabled images should look the same for any context (Label, Button, ToolItem, MenuItem, Canvas, ...).
And in my opinion there would be no need for the style guide convention of providing explicit disabled images at all, if the implicitly rendering of all disabled images in Windows would be good (like MenuItem).
Sadly the whole topic doesn't seem to interest anyone or hardly anyone here.
But if you want to know what I think - here are my ideas for improvement:
1) SWT automatic/implicitly rendering of disabled images under Windows should be the same for all contexts and the created images should look good (quality like MenuItem today).
2) Style guide convention and API of providing explicitly a disabled image should count and work for all contexts (Menu, Tool, Button, Label, Canvas, ...) (...OR it should be removed)
Lars I am really sorry, I looked into the GTK- and Win32-SWT code and I have not the "graphics"-API and -programming skills (OS specific and Java) to provide a patch or a solution. And when we are talking about the Style-Guide and the API of items and controls I am not the right person either.
|