Bug 505842

Summary:	[generic editor] Test failures in official build in HoverTest
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	Text	Assignee:	Mickael Istria <mistria>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtako
Version:	4.7	Keywords:	test
Target Milestone:	4.7 RC1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/83089 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=1a9d72873c8c8c2b74bc39442a3a66dc786a9cf2 https://git.eclipse.org/r/97056 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=36f184f16f456d9e67029e34ca68c98c9689d46f https://git.eclipse.org/r/97179 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=09a62775abf126886acce66c5aec7c378c73fdd8 https://git.eclipse.org/r/127877
Whiteboard:

Description Dani Megert

2016-10-13 03:45:00 EDT

N20161012-2000

http://download.eclipse.org/eclipse/downloads/drops4/N20161012-2000/testresults/html/org.eclipse.ui.genericeditor.tests_ep47N-
unit-mac64_macosx.cocoa.x86_64_8.0.html

Comment 1 Eclipse Genie

2016-10-13 04:55:20 EDT

New Gerrit change created: https://git.eclipse.org/r/83089

Comment 2 Mickael Istria

2016-10-13 04:56:47 EDT

I easily reproduced them with PDE tests, although they pass with Tycho.

Comment 3 Eclipse Genie

2016-10-13 05:22:48 EDT

Gerrit change https://git.eclipse.org/r/83089 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=1a9d72873c8c8c2b74bc39442a3a66dc786a9cf2

Comment 4 Mickael Istria

2016-10-13 05:23:15 EDT

Last patch works with PDE and Tycho.

Comment 5 Dani Megert

2016-10-28 09:29:12 EDT

Failed again:

http://download.eclipse.org/eclipse/downloads/drops4/I20161027-0700/testresults/html/org.eclipse.ui.genericeditor.tests_ep47I-unit-cen64_linux.gtk.x86_64_8.0.html

Comment 6 Mickael Istria

2016-11-08 10:51:57 EST

This test failure only happened once, in a build showing other unusual test failures. I'm tempted to close the issue as WORKSFORME and to blame (without any other proof) a bad environment mood for this specific set of failures.
@Dani: is this acceptable?

Comment 7 Dani Megert

2016-11-08 10:59:28 EST

(In reply to Mickael Istria from comment #6)
> This test failure only happened once, in a build showing other unusual test
> failures. I'm tempted to close the issue as WORKSFORME and to blame (without
> any other proof) a bad environment mood for this specific set of failures.
> @Dani: is this acceptable?

Sure. We can reopen if it happens again.

Comment 8 Dani Megert

2017-04-12 03:46:50 EDT

The failures are back on various platforms, see e.g.

http://download.eclipse.org/eclipse/downloads/drops4/I20170410-2000/testResults.php

or

http://download.eclipse.org/eclipse/downloads/drops4/I20170411-0500/testResults.php

Comment 9 Dani Megert

2017-05-10 06:01:42 EDT

Those failures cause noise. Please either fix or disable them for M7.

Comment 10 Mickael Istria

2017-05-10 06:11:39 EDT

I'd really like to fix them once and for all, but I admit I didn't find a good way to do it, as it involves waiting for popups to show up.
@Alex: would you please give me a hand with this one? It involves generating SWT events and waiting properly for a shell to be shown. I hope you can figure out how to make it more "stable" or think about a better way to achieve this.

Comment 11 Dani Megert

2017-05-12 10:26:09 EDT

(In reply to Mickael Istria from comment #10)
> I'd really like to fix them once and for all

That's nice, but disable them for RC1 if you can't fix them.

Comment 12 Eclipse Genie

2017-05-15 04:53:42 EDT

New Gerrit change created: https://git.eclipse.org/r/97056

Comment 13 Eclipse Genie

2017-05-15 06:55:41 EDT

Gerrit change https://git.eclipse.org/r/97056 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=36f184f16f456d9e67029e34ca68c98c9689d46f

Comment 14 Mickael Istria

2017-05-15 06:57:17 EDT

(In reply to Eclipse Genie from comment #13)
> Gerrit change https://git.eclipse.org/r/97056 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/
> ?id=36f184f16f456d9e67029e34ca68c98c9689d46f

This patch should help. Let's leave the issue open for now and see if this has improved things in next builds.
I believe I found a way to avoid some sporadic issue with completion; and for the hoverTest, I simply skip it on Windows as I don't have a clue about why it's failing there.

Comment 15 Mickael Istria

2017-05-16 01:26:55 EDT

Tests on Windows seem OK, but another test seems unstable.

Comment 16 Eclipse Genie

2017-05-16 03:46:29 EDT

New Gerrit change created: https://git.eclipse.org/r/97179

Comment 17 Eclipse Genie

2017-05-16 04:13:01 EDT

Gerrit change https://git.eclipse.org/r/97179 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=09a62775abf126886acce66c5aec7c378c73fdd8

Comment 18 Mickael Istria

2017-05-17 02:33:57 EDT

Last test suite (with the patches merged) didn't show any error regarding Generic Editor tests.

Comment 19 Eclipse Genie

2018-08-22 14:59:56 EDT

New Gerrit change created: https://git.eclipse.org/r/127877

Comment 20 Dani Megert

2018-08-23 12:57:05 EDT

(In reply to Eclipse Genie from comment #19)
> New Gerrit change created: https://git.eclipse.org/r/127877

What is this doing here? This bug is closed and VERIFIED since 2017.