Bug 502038

Summary: [CommonNavigator] Filters are not activated correctly in NavigatorFilterService
Product: [Eclipse Project] Platform Reporter: Jan Rosczak <jan.rosczak>
Component: UIAssignee: Jan Rosczak <jan.rosczak>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mistria, psuzzi
Version: 4.7Keywords: bugday
Target Milestone: 4.7 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/81880
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=96280fa5b5aa768a44b6815591c97121f6d46ad6
Whiteboard:
Bug Depends on:    
Bug Blocks: 167414    

Description Jan Rosczak CLA 2016-09-23 02:30:59 EDT 
The condition when a filter is activated and when a filter is deactivated needs to be the other way around. Currently a filter is deactivated when the boolean variable "toMakeActive" is true. This is clearly wrong.
Comment 1 Lars Vogel CLA 2016-09-23 03:00:05 EDT 
Patches are welcome
Comment 2 Patrik Suzzi CLA 2016-09-23 13:16:02 EDT 
Probably is to be fixed in NavigatorFilterService#setActive(..), to match the usage we see in ToggleFilterAction#run()
Comment 3 Jan Rosczak CLA 2016-09-24 02:16:53 EDT 
I have a patch pending and will submit it soon
Comment 4 Mickael Istria CLA 2016-09-24 12:57:38 EDT 
Thanks Jan. This indeed seems to be a bug. Do you have any example of workflow that highlight this bug in the user perspective?
Comment 5 Jan Rosczak CLA 2016-09-26 02:36:12 EDT 
It seems as if the class ToggleFilterAction which is the only class which calls the method setActive(String aFilterId, boolean toMakeActive) on the NavigationFilterService is not used anywhere.

Therefore I think that currently no workflow exists to highlight this bug. Only when I implement the MRU filters feature I make use of the ToggleFilterAction and the bug surfaces.
Comment 6 Eclipse Genie CLA 2016-09-26 02:42:00 EDT 
New Gerrit change created: https://git.eclipse.org/r/81880
Comment 8 Mickael Istria CLA 2016-09-26 12:55:23 EDT 
Patch merged, thanks Jan!