Bugzilla – Full Text Bug Listing
| Summary: | [Task view] Remove unused task view limit constants | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | UI | Assignee: | Harald Albers <eclipse> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | eclipse, Lars.Vogel, loskutov |
| Version: | 4.7 | Keywords: | helpwanted, noteworthy |
| Target Milestone: | 4.7 M2 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/77710 https://git.eclipse.org/r/77870 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=02fd026667d18936afe576e43e845f56e485c7b3 |
||
| Whiteboard: | |||
| Bug Depends on: | 498056, 498127 | ||
| Bug Blocks: | |||
|
Description
Lars Vogel
(In reply to Lars Vogel from comment #0) > +++ This bug was initially created as a clone of Bug #498056 +++ > We should do the same for the task view. I think for the task view the workspace selection might makes sense. This bug is only for increasing the limit. The limit is already set to 1000. The following settings have no effect and can safely be deleted: org.eclipse.ui.internal.ide.IDEInternalPreferences.TASKS_LIMIT org.eclipse.ui.internal.ide.IDEInternalPreferences.LIMIT_TASKS Adjusting the issue's subject to these findings. > Adjusting the issue's subject to these findings.
Apparently I'm no authorized to do so.
Please consider the subject to be changed to
"Remove unused task view limit constants"
New Gerrit change created: https://git.eclipse.org/r/77710 Thanks Harald. Change looks good to me but as I soon leave for vacation and that this _might_ cause issues downstream, I plan to look at that after my vacation. If another committer wants to have a look, please feel free. There was some confusion about this change: When I created https://git.eclipse.org/r/77710, the value was already changed to 1000. I changed the issue to a cleanup one. In the meantime, the setting was reverted to 100 by Lars Vogel, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=498056#c26 So I will change the subject back to its original intent and add another change set that just increases the setting to 1000 again. The cleanup from https://git.eclipse.org/r/77710 is not affected by this and still remains active. New Gerrit change created: https://git.eclipse.org/r/77870 (In reply to Eclipse Genie from comment #7) > New Gerrit change created: https://git.eclipse.org/r/77870 This was rejected, without a performance tests that proves that the error view still refreshes. See discussion in https://bugs.eclipse.org/bugs/show_bug.cgi?id=498056 Gerrit change https://git.eclipse.org/r/77710 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=02fd026667d18936afe576e43e845f56e485c7b3 Thanks Harald |