Bug 481674

Summary:	Settings page aria-labelledby 'Navigation-header' doesn't exist
Product:	[ECD] Orion (Archived)	Reporter:	Carolyn MacLeod <Carolyn_MacLeod>
Component:	Client	Assignee:	Carolyn MacLeod <Carolyn_MacLeod>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	unspecified	Keywords:	accessibility
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/59917 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bc69e67857d77e0ac51ba49d06d1ecd2b054d119
Whiteboard:

Description Carolyn MacLeod

2015-11-08 22:58:05 EST

In file settings/Subsection.js the subsection's aria-labelledby attribute is set to 'Navigation-header', but there isn't any element with 'Navigation-header' id.

The titleNode element is probably the element that was intended to be the label for the section, however if all titleNode elements were given an id of 'Navigation-header' then the id would not be unique.

The patch creates a unique id based on sectionName (which is the text for the titleNode element).

Comment 1 Eclipse Genie

2015-11-08 23:03:34 EST

New Gerrit change created: https://git.eclipse.org/r/59917

Comment 2 Eclipse Genie

2015-11-10 13:40:25 EST

Gerrit change https://git.eclipse.org/r/59917 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bc69e67857d77e0ac51ba49d06d1ecd2b054d119

Comment 3 Carolyn MacLeod

2015-11-10 23:23:23 EST

Fixed by commit in comment 2.