Bugzilla – Full Text Bug Listing
| Summary: | Poor Contrast in Accelerator Text when Menu is highlight | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion (Archived) | Reporter: | Steve Northover <steve_northover> | ||||
| Component: | Client | Assignee: | Jefferson Lam <jwlam> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | Carolyn_MacLeod, curtis.windatt.public, john.arthorne, Silenio_Quarti, steve_northover | ||||
| Version: | unspecified | Keywords: | accessibility | ||||
| Target Milestone: | 10.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
There are likely other places in Orion where contrast is bad but let's find and fix this one first. There are likely other places in Orion where contrast is bad but let's find and fix this one first. In case it's helpful: http://webaim.org/resources/contrastchecker/ http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4d3b9923254236c79a2862fad745aa20f52a0e73 Jefferson suggested this one line fix which I tested and approved. Fixed this bug by removing this line from theme.css:
.dropdownMenuItem .dropdownKeyBinding {
- color: grey !important; /* !important to override .dropdownMenuItem */
...
Fix was pushed by Curtis.
|
Created attachment 255033 [details] A picture of the problem 1) Run Orion 2) File->Undo ... (NOTE: just highlight the item, don't select it) 3) BUG: The accelerator text Ctrl+Z is dim and hard to read Likely, the accelerator text color should be the same as the normal menu item text color.