Bugzilla – Full Text Bug Listing
| Summary: | [GTK] Flipped button order and default button | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Marvin Fröhlich <eclipse> |
| Component: | SWT | Assignee: | Markus Keller <markus.kell.r> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | arunkumar.thondapu, Lars.Vogel, lshanmug, malaperle, markus.kell.r, niraj.modi, stephan.herrmann |
| Version: | 4.5 | ||
| Target Milestone: | 4.6 M4 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/51294 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=39342ffc9e64b250c13f32265b898e0c6e960a40 https://git.eclipse.org/r/59042 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d166f958b55c0c62dde5c74dee5645ea913de43e |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 480806, 479727 | ||
|
Description
Marvin Fröhlich
If you're on KDE, than this might be the result of the GTK theme in use: in previous releases of, e.g., Kubuntu, oxygen-gtk was the default theme for GTK applications which had Eclipse follow the KDE style wrt button order. Neither can oxygen-gtk be recommended for recent versions of Eclipse when running on GTK3, nor does Kubuntu 15.04 use this theme by default. I'm yet to find a theme that works well for Eclipse on GTK3 and preserves the KDE-conform button order, but Andrey may have some workarounds for this, for a start you may refer to http://www.jroller.com/andyl/entry/mars_on_linux Yes, I am on KDE, OpenSuSE 13.1. I am using GTK3 theme Adviata as of KDE system settings. Thanks for the link. Unfortunately it's dead though. JFace relies on Display#getDismissalAlignment(), which reads GTK's "gtk-alternative-button-order" property. This code hasn't been touched for years. Well, I am not sure, if this topic should be closed. We elaborated some kind of a workaround. But the problem, that the wrong button is enabled by default, still exists. If you don't restore the original button order the "Details" button is focussed by default, which is plain wrong and annoying. This should be fixed, shouldn't it? (In reply to Marvin Fröhlich from comment #4) > If you don't restore the original button order the "Details" button is > focussed by default, which is plain wrong and annoying. This should be > fixed, shouldn't it? Yes, I missed that part of the bug. For the Export > JAR file scenario, the dialog is an org.eclipse.jface.dialogs.ErrorDialog. However, there are quite a few other similar dialogs, e.g. org.eclipse.ui.internal.statushandlers.InternalDialog. MessageDialog#createButton(..) already hacks around this problem, thereby violating OS X conventions. On OS X, the focused button can be activated with the Space key, but the focus doesn't override the default button (which stays accessible via the Enter key). I think this should be fixed in SWT for GTK, probably via the commented code in org.eclipse.swt.widgets.Decorations#restoreFocus(). Note that this text was recently removed from the comment there: "Motif doesn't do this." New Gerrit change created: https://git.eclipse.org/r/51294 (In reply to Eclipse Genie from comment #6) > New Gerrit change created: https://git.eclipse.org/r/51294 The same should be done for win32. An example is the Delete dialog for files in the Package Explorer. org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDialog2#createButtonsForButtonBar(Composite) currently forces the focus on the OK button. That's wrong on the Mac, where the "Preview >" button should have focus initially. RefactoringWizardDialog2 and MessageDialog can only be fixed after this bug has been fixed on win32 and GTK. (In reply to Markus Keller from comment #7) > (In reply to Eclipse Genie from comment #6) > > New Gerrit change created: https://git.eclipse.org/r/51294 > > The same should be done for win32. An example is the Delete dialog for files > in the Package Explorer. > org.eclipse.ltk.internal.ui.refactoring. > RefactoringWizardDialog2#createButtonsForButtonBar(Composite) currently > forces the focus on the OK button. That's wrong on the Mac, where the > "Preview >" button should have focus initially. > > RefactoringWizardDialog2 and MessageDialog can only be fixed after this bug > has been fixed on win32 and GTK. Created bug 479727 to track Win32 changes. Gerrit change https://git.eclipse.org/r/51294 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=39342ffc9e64b250c13f32265b898e0c6e960a40 Tested the patch and pushed it, thanks Markus, do you intend to provide a patch for the win32 changes as well? This seems to have broken some focus behavior, see bug 480770. Reopened as of comment 11 New Gerrit change created: https://git.eclipse.org/r/59042 (In reply to Eclipse Genie from comment #13) > New Gerrit change created: https://git.eclipse.org/r/59042 This fixes bug 480770 and the cases mentioned in this bug. Should only be released after M3, ideally together with bug 479727. Gerrit change https://git.eclipse.org/r/59042 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d166f958b55c0c62dde5c74dee5645ea913de43e . |