Bugzilla – Full Text Bug Listing
| Summary: | EGit staging view and commit page are not properly styled | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Fabio Zadrozny <fabiofz> | ||||||||||
| Component: | UI | Assignee: | Fabio Zadrozny <fabiofz> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | Lars.Vogel, loskutov, matthias.sohn | ||||||||||
| Version: | 4.0 | Keywords: | greatfix | ||||||||||
| Target Milestone: | 4.0 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows NT | ||||||||||||
| See Also: |
https://git.eclipse.org/r/46663 https://git.eclipse.org/c/egit/egit.git/commit/?id=9f205d27a374f295930e4b36ed0fd988d62959d3 https://bugs.eclipse.org/bugs/show_bug.cgi?id=466486 |
||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
thanks for fixing that :-) (In reply to Fabio Zadrozny from comment #0) > Created attachment 252841 [details] > Picture showing issue > > Currently when using the dark theme (on 4.5M7) the staging view and the > commit page are not properly styled (see picture attached). > > I'll provide a patch in gerrit to fix that shortly (mostly adding some css > to fix it). Fabio, please make sure the fix is also for the standard theme too, not only for the dark one. New Gerrit change created: https://git.eclipse.org/r/46663 (In reply to Andrey Loskutov from comment #2) > (In reply to Fabio Zadrozny from comment #0) > > Created attachment 252841 [details] > > Picture showing issue > > > > Currently when using the dark theme (on 4.5M7) the staging view and the > > commit page are not properly styled (see picture attached). > > > > I'll provide a patch in gerrit to fix that shortly (mostly adding some css > > to fix it). > > Fabio, please make sure the fix is also for the standard theme too, not only > for the dark one. Hi Andrey, Humm, I don't quite follow that... the standard theme should be fine already right? (i.e.: it uses the default light colors, so, the issue is only in the dark theme) If I'm missing something, can you explain it a bit more so that I follow your thoughts? Created attachment 252843 [details]
Picture with the patch applied
Adding a picture which shows the results after applying the patch.
(In reply to Fabio Zadrozny from comment #4) > Humm, I don't quite follow that... the standard theme should be fine already > right? (i.e.: it uses the default light colors, so, the issue is only in the > dark theme) > > If I'm missing something, can you explain it a bit more so that I follow > your thoughts? Without to know if there are specific code for the standard theme required I just wanted to make sure if we fix something for one theme, the another one is fixed too. So if there are no extra settings for the standard one needed, it's OK. Thanks Fabio for fixing that. Created attachment 252848 [details]
Picture with the patch applied
As a note, I'm uploading a new 'after' snapshot (that one was a temporary one which was wrong -- it's almost the same, but if you look closely you'll see that other elements changed the background when they shouldn't be changed).
Is there someone from EGit which could take a look at this change? The dark theme looks much nicer with it ;) Thanks. I can review your change later today Created attachment 252915 [details]
commit dialog and staging view on Mac
on Mac the filter box in the Commit Dialog is still white, can this be fixed ?
merged as http://git.eclipse.org/c/egit/egit.git/commit/?id=9f205d27a374f295930e4b36ed0fd988d62959d3 (In reply to Matthias Sohn from comment #11) > Created attachment 252915 [details] > commit dialog and staging view on Mac > > on Mac the filter box in the Commit Dialog is still white, can this be fixed > ? Not sure (unfortunately I won't be able to look at that now, so, please create a new issue for that). *** Bug 448784 has been marked as a duplicate of this bug. *** See Bug 466486 for the styling of the Push dialog |
Created attachment 252841 [details] Picture showing issue Currently when using the dark theme (on 4.5M7) the staging view and the commit page are not properly styled (see picture attached). I'll provide a patch in gerrit to fix that shortly (mostly adding some css to fix it).