Bugzilla – Full Text Bug Listing
| Summary: | [JUnit] "Next/Previous Failed Test" buttons enabled on "Show Skipped Tests Only" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Markus Keller <markus.kell.r> | ||||
| Component: | UI | Assignee: | Noopur Gupta <noopur_gupta> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | minor | ||||||
| Priority: | P3 | CC: | andrej, daniel_megert, markus.kell.r, noopur_gupta | ||||
| Version: | 4.5 | Flags: | markus.kell.r:
review+
|
||||
| Target Milestone: | 4.5 M7 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://git.eclipse.org/r/46681 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Markus Keller
Created attachment 252846 [details] Patch to disable Next/Previous buttons with "Show Skipped Tests Only" (In reply to Markus Keller from comment #0) > When Show Skipped Tests Only (bug 298603) is enabled in the JUnit view, the > "Next/Previous Failed Test" buttons don't work any more. They are enabled if > the test run session had errors, and they are disabled if all non-skipped > tests are green. > > They at least need to be disabled when they don't work. A better solution > would be to change them to "Next/Previous Skipped Test" in that case. Attached patch disables the "Next/Previous Failed Test" buttons when "Show Skipped Tests Only" filter is applied. The buttons can be changed to "Next/Previous Skipped Test" buttons in a separate patch later. Markus, please have a look. Looks good, and I trust you that it works. Please commit. New Gerrit change created: https://git.eclipse.org/r/46681 Released the patch via: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=80a8879beff3141dbc2da105941c631799924aea (In reply to Noopur Gupta from comment #1) > The buttons can be changed to "Next/Previous Skipped Test" buttons in a > separate patch later. Reported bug 465695. |