Bug 46356

Summary:	[Builder] simple/qualified names list for indicting dependents should be hashed collections
Product:	[Eclipse Project] JDT	Reporter:	Philipe Mulet <philippe_mulet>
Component:	Core	Assignee:	Kent Johnson <kent_johnson>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.0
Target Milestone:	3.0 M5
Hardware:	PC
OS:	Windows 2000
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=529984
Whiteboard:

Description Philipe Mulet

2003-11-10 12:26:52 EST

Build 3.0 M4

We could use sets in the IncrementalJavaBuilder qualifiedStrings/simpleStrings) 
collections. Also there are APIs to add which answer true only if not present 
already (if using sets, this is exactly what you would want).
This is in IncrementalImageBuilder#addDependentsOf

Offending scenario is a manual rebuild of one project followed by workspace 
incremental rebuilt. Lots of names are accumulated during the indictment 
process.

Comment 1 Philipe Mulet

2003-11-10 12:27:17 EST

Should be backported to 2.1 stream when fix is available.

Comment 2 Kent Johnson

2003-11-10 18:18:34 EST

Made the changes but did not see an improvement rebuilding core.runtime 
followed by an incremental build of the rest of the workspace (full source 
Eclipse workspace).

Changed IncrementalImageBuilder and ReferenceCollection. Added StringSet.

Comment 3 David Audel

2003-11-24 06:58:55 EST

Verified.