Bug 446546

Summary:	[CSSLint] Use configurable severities as ruleset rather than a post processing filter
Product:	[ECD] Orion (Archived)	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	Client	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	performance
Version:	6.0
Target Milestone:	7.0
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	445540
Bug Blocks:

Description Curtis Windatt

2014-10-09 17:20:42 EDT

The current implementation of configurable severities for CSSLint simply filters out problems thta match a rule who's severity is 'ignore'.  Instead we should be creating a ruleset to pass into the CSSLint.verify() call.  This allows those rules to be skipped entirely.

Comment 1 Curtis Windatt

2014-10-14 16:47:26 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6ea2bae3faecc9772b4ee5ddec074188ae903ad3
Sets a ruleset rather than changing severities after the fact

Also fixes an issue with the settings name

This allows embedded rulesets to work (Bug 445544).  

CSSLint always changes the severity of parsing errors to 'error' so I removed the severity option from the settings.