Bug 444840

Summary:	[IDE] IDE.getEditorId(IFileStore) is private
Product:	[Eclipse Project] Platform	Reporter:	Jonah Graham <jonah>
Component:	UI	Assignee:	Tomasz Zarna <tomasz.zarna>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, jonah, prakash, tomasz.zarna
Version:	4.5	Keywords:	bugday, greatfix, helpwanted
Target Milestone:	4.5 M6
Hardware:	PC
OS:	Linux
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=230865 https://git.eclipse.org/r/42083 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=23748ba665160ecbd52d90faabb18d881a836ed7
Whiteboard:
Bug Depends on:
Bug Blocks:	516470

Description Jonah Graham

2014-09-23 09:20:42 EDT

When Bug 230865 was fixed it appears that IDE.getEditorId was under consideration for being made public (Bug 230865 Comment 9), but there was no immediate/obvious need for it. I would like to make use of that method so I can get an Editor ID for a file based on content type, but at a point where I don't want to/can't open the editor (so I can't use IDE.openEditorOnFileStore).

Can this method be made public?

Comment 1 Paul Webster

2014-09-29 09:41:04 EDT

See https://wiki.eclipse.org/Platform_UI/How_to_Contribute

PW

Comment 2 Tomasz Zarna

2015-02-17 18:04:10 EST

https://git.eclipse.org/r/42083

Comment 3 Dani Megert

2015-02-18 06:39:19 EST

(In reply to Jonah Graham from comment #0)
> When Bug 230865 was fixed it appears that IDE.getEditorId was under
> consideration for being made public (Bug 230865 Comment 9)

At that point the method returned the editor descriptor. Adding a public method that only returns the ID is not good. Note though, that you can't name the method 'getEditorDescriptor', because of bug 148844.

Comment 4 Eclipse Genie

2015-02-19 07:44:51 EST

Gerrit change https://git.eclipse.org/r/42083 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=23748ba665160ecbd52d90faabb18d881a836ed7

Comment 5 Dani Megert

2015-02-19 07:45:12 EST

Comment 6 Jonah Graham

2017-05-11 05:27:23 EDT

Sadly this fix was accidentally clobbered, see Bug 460652 Comment 8. I have opened new bug 516470 to add it back in.

Comment 7 Eclipse Genie

2017-05-11 05:40:23 EDT

New Gerrit change created: https://git.eclipse.org/r/96800