Bugzilla – Full Text Bug Listing
| Summary: | Syntax error in TestUtil in org.eclipse.e4.ui.menu.tests | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bjoern.seebeck, daniel_megert, Lars.Vogel, pwebster |
| Version: | 4.4 | Keywords: | test |
| Target Milestone: | 4.5 M1 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 440849 | ||
Just checked out the code and got this error. A little bit confusing to new committers. Dani, Paul how comes we have a syntax error in our tests? Do we not run org.eclipse.e4.ui.menu.tests in our automated test run? No, that one isn't included in our builds. We should compare that with the MenuTestSuite in org.eclipse.ui.tests, and if the o.e.ui.tests one is comparable we can remove the other one. Fix for the syntax error and adds README.md for the task to compare with the MenuTestSuite in org.eclipse.ui.tests. https://git.eclipse.org/r/#/c/30780/ To consider this done the bundle version needs to be incremented. (In reply to Dani Megert from comment #6) > To consider this done the bundle version needs to be incremented. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cdaba77c534e1f6b10f60e144ef07ad1c3e522a8 Verified in I20140804-2000. (In reply to Paul Webster from comment #3) > We should compare that with the MenuTestSuite in org.eclipse.ui.tests, and > if the o.e.ui.tests one is comparable we can remove the other one. I prefer we leave them separate to have your e4 menu tests separate from the "old" menu tests. |
I get a syntax error in appContext.set(IResourceUtilities.class, new ISWTResourceUtilities() { it complains adornImage must also be implemented. Are others seeing the same error?