Bugzilla – Full Text Bug Listing
| Summary: | Provide launchers for ppc64le | ||
|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Alexander Kurtakov <akurtakov> |
| Component: | Launcher | Assignee: | Project Inbox <equinox.launcher-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | arunkumar.thondapu, daniel_megert, mat.booth, stephen.francisco, tjwatson |
| Version: | unspecified | Keywords: | plan |
| Target Milestone: | Mars | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 431232 | ||
|
Description
Alexander Kurtakov
Patch: https://git.eclipse.org/r/#/c/24569/ In order to test successfully one needs to create corresponding dir in rt.equinox.binaries but there is no sensible way to add this as git doesn't support empty dirs. Should we have empty file in it for the sake of allowing build? I released the patch with: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=ad7c0ec6c65e7a2c843ef2745ffe8ac27deffb45 (In reply to Alexander Kurtakov from comment #1) > Patch: https://git.eclipse.org/r/#/c/24569/ > In order to test successfully one needs to create corresponding dir in > rt.equinox.binaries but there is no sensible way to add this as git doesn't > support empty dirs. Should we have empty file in it for the sake of allowing > build? Hmmm, I don't know what the right answer is for this. If creating a README file to get an "empty" dir helps to make progress I don't see a big issue with doing that. I guess I will still leave this bug open. Alexander, close if you think we are done for the purpose of this bug. An idea that came a bit late to me - use maven profiles to enable the module containing the fragment if -Dnative=gtk.linux.ppc64le is passed. Patch: https://git.eclipse.org/r/#/c/24743/ (In reply to Alexander Kurtakov from comment #3) > An idea that came a bit late to me - use maven profiles to enable the module > containing the fragment if -Dnative=gtk.linux.ppc64le is passed. > Patch: https://git.eclipse.org/r/#/c/24743/ Thanks, I think that is a good idea. I pushed to master: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=9a3dee0428c65629c5d35fe7f5d7b36d84fdbae6 Alex, can this be considered complete based on bug #441358 and bug #442290? Yes, resolving it now. |