Bugzilla – Full Text Bug Listing
| Summary: | [api] provide API in connector core to validate repositories | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> |
| Component: | Mylyn | Assignee: | Frank Becker <eclipse> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | eclipse |
| Version: | unspecified | Keywords: | noteworthy |
| Target Milestone: | 3.11 | ||
| Hardware: | Macintosh | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
Frank, I pushed a review to https://git.eclipse.org/r/#/c/20529/1 with an initial implementation to demonstrate what I have in mind in terms of generalizing the API and tests. The ValidationTest is fully connector agnostic so it could be run for any connector that implements the API. That way we don't end up duplicating tests but only really need to implement them once. There are still some pieces missing such as dynamically discovery of the connector kind instead of using the hard coded annotation but it should give you an idea. Frank, I'll assign this to you since you already did part of the work. It would be great to merge the relevant parts from review https://git.eclipse.org/r/#/c/19178/ into the review from comment #1. Frank, I think this is complete. Please reopen if there is still anything outstanding here. |
The API for validating repository connections that is currently in AbstractRepositorySettingsPage should be moved to the connector core to make it accessible outside of the settings page context. The implementation should return information about the repository, e.g.: RepositoryStatus validate(TaskRepository repository, IProgressMonitor monitor) throws CoreException class RepositoryStatus { RepositoryVersion getVersion(); }