Bug 417876

Summary: better content assist support for node.js
Product: [ECD] Orion (Archived) Reporter: Manu Sridharan <m.sridharan>
Component: JS ToolsAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: unspecifiedKeywords: noteworthy
Target Milestone: 4.0 RC1   
Hardware: PC   
OS: Mac OS X   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=418356
Whiteboard:

Description Manu Sridharan CLA 2013-09-23 18:48:52 EDT
I've implemented better content assist support for node.js in this branch:

https://github.com/msridhar/orion.client/tree/node-modules

Here is the commit:

https://github.com/msridhar/orion.client/commit/c06714456e25de4df148f421384757662322c62f

See the commit comment for further details.  If there are any questions, please let me know.
Comment 1 Mark Macdonald CLA 2013-09-30 11:42:22 EDT
I pushed the changes -- thanks Manu. However I did find a few issues with the "Buffer"-related globals -- see bug 418356.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=931be5b
Comment 2 Mark Macdonald CLA 2013-09-30 11:44:38 EDT
Also added the indexFileParsing tests to our build-time test suite:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5033b78