Bug 415958

Summary:	RepositoryAction checks enabled on each text selection change
Product:	[Technology] EGit	Reporter:	Robin Stocker <robin>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn
Version:	3.0	Keywords:	performance
Target Milestone:	3.0.2
Hardware:	All
OS:	All
Whiteboard:

Description Robin Stocker

2013-08-27 10:30:59 EDT

When selecting text in a file, each change of the selection causes RepositoryAction#selectionChanged to be called with an ITextSelection.

selectionChanged in turn updates the enabled state by calling isEnabled on the handler. isEnabled may involve reading refs or repository config.

The above is multiplied by the number of actions, so it should be avoided. Fix upcoming.

Comment 1 Robin Stocker

2013-08-27 10:38:02 EDT

Proposed fix: https://git.eclipse.org/r/15896

Comment 2 Matthias Sohn

2013-09-01 18:38:24 EDT

merged as 374318a5590575c136dfe11273e391ea923d4795