Bug 415101

Summary: Markdown: inline images with an empty alt text are not rendered
Product: z_Archived Reporter: Robert Munteanu <robert.munteanu>
Component: MylynAssignee: Stefan Seelmann <mail>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: greensopinion, mail, steffen.pingel
Version: 1.8Keywords: contributed
Target Milestone: 2.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Screenshot of how the code snippet is rendered none

Description Robert Munteanu CLA 2013-08-14 15:33:05 EDT
Consider the following markdown file

bc.. 
	![](images/Time-tracking-action.png)
![](images/Time-tracking-action.png)

	![Alt text](images/Time-tracking-action.png)
![Alt text](images/Time-tracking-action.png)

p. Only the second block is rendered, which is incorrect, since the alt attribute text is not required to be empty.
Comment 1 Robert Munteanu CLA 2013-08-14 15:34:13 EDT
Created attachment 234428 [details]
Screenshot of how the code snippet is rendered
Comment 2 Stefan Seelmann CLA 2013-08-16 17:14:18 EDT
Thanks Robert for the bug report. I agree that this is not the correct behaviour, thought that this is not defined by the spec, but other implementations accect an empty alt text.

I uploaded a review request: https://git.eclipse.org/r/#/c/15558/

Beside the main issue (empty alt text in images) now the parser also accepts an empty title. Additional it also accepts empty link text for links, this is not very useful but compatible to other Markdown implementations. Fixed for both inline and reference style images and links.
Comment 3 Steffen Pingel CLA 2013-10-14 23:38:45 EDT
David, are you planning to merge the change? We are planning to submit the IP log tomorrow so it would have to be in master by then.
Comment 4 David Green CLA 2013-10-25 19:08:17 EDT
Sorry I missed the cut-off for the release.  I've merged the change now.

Thanks for the contribution Stefan.